Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Migrate to orb tools 11 config #43

Merged
merged 5 commits into from
Oct 7, 2022
Merged

refactor: Migrate to orb tools 11 config #43

merged 5 commits into from
Oct 7, 2022

Conversation

KyleTryon
Copy link
Contributor

No description provided.

@KyleTryon KyleTryon marked this pull request as ready for review October 7, 2022 15:26
echo "DEBUG: Single image repo"
echo "DEBUG: ${ARRAY_REPOSITORIES[0]}"
set -- "$@" --image-repository "$(eval echo "${ARRAY_REPOSITORIES[0]}")"
echo "DEBUG: Single image repo named ${ARRAY_REPOSITORIES[0]}" | tee -a /tmp/sam.log
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these debugs necessary?

echo "Images: ${#ARRAY_REPOSITORIES[@]}"
echo "DEBUG: ${ARRAY_REPOSITORIES[image]}"
set -- "$@" --image-repositories "$(eval echo "${ARRAY_REPOSITORIES[image]}")"
echo "DEBUG: Multi image repo" "${ARRAY_REPOSITORIES[$image]}" | tee -a /tmp/sam.log
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with this debug and the one below

Copy link
Contributor

@brivu brivu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@KyleTryon KyleTryon merged commit ccc0527 into master Oct 7, 2022
@KyleTryon KyleTryon deleted the ot-11 branch October 7, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants