feat!/auth-step-parameter #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleTryon
reviewed
Mar 29, 2023
| @@ -15,6 +17,9 @@ usage: | |||
| deploy_image: | |||
| jobs: | |||
| - sam/deploy: | |||
| auth: | |||
| # Configure aws credentials with static keys stored as env_vars (AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY) | |||
There was a problem hiding this comment.
Reminder that these notes do not render in the orb registry
There was a problem hiding this comment.
Thanks, I've added them in the example's description as well to be thorough
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
PRadds theauthparameter to thesam/deployjob, requiring users to customize their authentication method by importing theaws-cliorb and using theaws-cli/setupcommand to authenticate using staticAWSkeys or a validrole-arnforOIDC.