-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: orb tools 12 migration #60
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brivu
force-pushed
the
refactor/orb-tools-12-migration
branch
from
June 14, 2023 04:55
45eba91
to
40b59dd
Compare
EricRibeiro
suggested changes
Jun 14, 2023
Co-authored-by: Eric Ribeiro <ericribeiro@outlook.com.br>
Co-authored-by: Eric Ribeiro <ericribeiro@outlook.com.br>
Co-authored-by: Eric Ribeiro <ericribeiro@outlook.com.br>
EricRibeiro
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This
PR
updates theAWS SAM Severless
Orb to the new major version of Orb Tools. As it contains breaking changes, several modifications were unnecessary to move from v11 to v12.Changes
-
with_
).Changes in
.circleci/config.yml
:orb-tools/publish
toorb-tools/continue
.orb-tools/publish
job since development versions are no longer necessary.orb_name
parameter inorb-tools/continue
.orb-tools/continue
job parameters to comply with the new snake case standard.orb_name
,pipeline_number
andvcs_type
.Changes in
.circleci/test-deploy.yml
:11.6
to12.0
.aws-cli: circleci/aws-cli@dev:<<pipeline.git.revision>>
line, and replace it withaws-cli: {}
.orb-tools/lint
,orb-tools/pack
, andorb-tools/review
jobs.orb-tools/publish
job parameters to comply with the new snake case standard.orb_name
,vcs_type
,pub_type
,enable_pr_comment
andgithub_token
.orb-tools/pack
filter to trigger only on tagged releases.test-deploy.yml
as they already run inconfig.yml
. See Orb-Template #2.