Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hadolint command expects Hadolint to be installed locally, doesn't use Docker image #170

Closed
hbielenia opened this issue Nov 29, 2022 · 1 comment · Fixed by #175
Closed
Assignees

Comments

@hbielenia
Copy link

Orb version

2.1.4

What happened

Upon trying to run the hadolint command, I'm getting following error:

Running hadolint with the following options...


/bin/bash: line 24: hadolint: command not found

Exited with code exit status 127

Apparently, the command expects hadolint to be installed locally and available as executable, despite the description clearly stating that it's using a hadolint Docker image: https://hub.docker.com/r/hadolint/hadolint.

Expected behavior

Hadolint should be pulled from Docker repository and executed in Docker container, with no need to install additional dependencies.

@brivu brivu linked a pull request Feb 16, 2023 that will close this issue
@brivu
Copy link
Contributor

brivu commented Feb 17, 2023

Hey @hbielenia,

Thank you for letting us know. You have a couple of options here:

  1. You can use the hadolint docker image in your job to run this command.
  2. You can just use the hadolint job.

Having said that, I've added validation to this command to check and see if hadolint is installed. If not, the command will now install hadolint for you.

I've added this in PR #175.

Hope that helps!

@brivu brivu self-assigned this Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants