Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install hadolint for hadolint command #175

Merged
merged 7 commits into from
Feb 21, 2023
Merged

Conversation

brivu
Copy link
Contributor

@brivu brivu commented Feb 16, 2023

Currently if the docker/hadolint command is used with an executor other than the hadolint docker image, the command fails. This PR installs hadolint if it isn't already.

@brivu brivu requested a review from a team as a code owner February 16, 2023 23:11
@brivu brivu self-assigned this Feb 16, 2023
src/scripts/hadolint.sh Outdated Show resolved Hide resolved
@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/docker?version=dev:a06236d8e3340e54b8c3c4fb9e95776084a35733

@brivu brivu requested a review from EricRibeiro February 17, 2023 23:26
@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/docker?version=dev:c738e3152f32245b721d8aad4fa33f3c08b54386

@brivu brivu requested a review from KyleTryon February 21, 2023 16:14
@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/docker?version=dev:c738e3152f32245b721d8aad4fa33f3c08b54386

@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/docker?version=dev:fd6f8a79381e3f7e7603519341eefe854f8a5c2d

@brivu brivu merged commit b6600db into master Feb 21, 2023
@brivu brivu deleted the fix/install-hadolint branch February 21, 2023 20:49
@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/docker?version=dev:b6600db35dd7b9b376f91b3e0fd27dcabc538125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hadolint command expects Hadolint to be installed locally, doesn't use Docker image
4 participants