Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: do not fall back to source builds of Node.js #185

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

dsanders11
Copy link
Contributor

Closes #183.

Opening a PR to get the ball rolling on this, been bit a few times now by this.

cc @KyleTryon

@dsanders11 dsanders11 requested a review from a team as a code owner July 3, 2023 16:49
@dsanders11
Copy link
Contributor Author

Note that this change would break Windows, since nvm-windows does not support the -b option. This orb does not officially support Windows, but for practical purposes it does work for Windows (#32 was closed on this basis), but I think the orb needs to clarify an official stance (IMO it should officially support Windows).

@olleolleolle
Copy link
Contributor

Oh, I'd like this, even if it were an option I had to pass to the node-orb settings.

@olleolleolle
Copy link
Contributor

Oh, just now I wanted this feature, the Node 20 build was just too long for the 10-minute window that I had.

cc @KyleTryon Do you know whether this is something planned or anything?

@KyleTryon
Copy link
Contributor

Oh, just now I wanted this feature, the Node 20 build was just too long for the 10-minute window that I had.

cc @KyleTryon Do you know whether this is something planned or anything?

I am no longer an employee of CircleCI. Sorry, I have no insight into anything planned in this org any longer.

@olleolleolle
Copy link
Contributor

@KyleTryon Thanks for responding, and sorry to notify you about this. May your weekend be excellent.

@orb-publisher
Copy link

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/circleci/node?version=dev:9ba92079fdaa31fabfb3309ae4cd63a6975439f0

@marboledacci marboledacci merged commit a961cb5 into CircleCI-Public:master Aug 28, 2024
2 checks passed
@dsanders11 dsanders11 deleted the patch-13 branch September 18, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent nvm from falling back to building from source
5 participants