Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eth subscriptions #113

Merged
merged 21 commits into from
Mar 29, 2022
Merged

Fix eth subscriptions #113

merged 21 commits into from
Mar 29, 2022

Conversation

llunaCreixent
Copy link
Member

@llunaCreixent llunaCreixent commented Mar 22, 2022 •
edited
Loading

Tasks:

  • Update dependencies
  • Fix websocket connection
  • Make lint happy (npm run lint)
  • Clean code (remove tests, remove wait functions)
  • Squash commits
  • Clean unused api container images in registries

@llunaCreixent llunaCreixent mentioned this pull request Mar 23, 2022
Merged
5 tasks
@llunaCreixent llunaCreixent requested a review from JacqueGM March 24, 2022 09:21
JacqueGM
JacqueGM reviewed Mar 24, 2022
View reviewed changes
.nvmrc Outdated
14.19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EOF

@llunaCreixent llunaCreixent requested a review from JacqueGM March 24, 2022 14:58
@llunaCreixent llunaCreixent marked this pull request as ready for review March 29, 2022 10:40
@JacqueGM
Copy link
Contributor

LGTM!

@llunaCreixent llunaCreixent merged commit c031870 into main Mar 29, 2022
@llunaCreixent llunaCreixent deleted the clear-eth-subscriptions branch March 29, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacqueGM JacqueGM JacqueGM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@llunaCreixent @JacqueGM