-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
News activity log #164
News activity log #164
Conversation
So from the myxogastria frontend we want to use the core in the same way as for transaction and trust log. The simplest way to deal with notifications would be if the response from this API resembles the format of the notifications from the graph when calling
The most important RESPONSE criteria is:The returned data/response has attribute Each of these objects have the following attributes:
Further more we don't want to include inactive news in the response. Of course there can also be a parsing function in the core to ensure this format. So these are preferences. Let me know what you think. REQUEST criteriaThe query we want to be able to make is guided by the same principles as for the graph notification queries, which has the following parameters:
|
@louilinn thanks for the definition.
The rest of the formatting will be done in the core, adding:
For enhancement, we could add the language in the query. Right now the code assumes only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good 🌟
Requests:
- fix the word mistake in test description
- Please complement the test to include inactive items, see comment.
- improve parameter docs
Closes #124
The field
active
is added in order to preserve entries that might be useful in the future.Tasks:
Deploying in prod requires coordination with db migrations