Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve search for usernames #86

Merged
merged 2 commits into from
Jun 21, 2021
Merged

Improve search for usernames #86

merged 2 commits into from
Jun 21, 2021

Conversation

adzialocha
Copy link
Collaborator

@adzialocha adzialocha commented Jun 17, 2021 •
edited
Loading

This PR improves the UX for searching usernames (in the wallet).

Searching for test led to the following results before:

atest
btest
csomenamewithtest
test
testAser
testHello
xtestxa

After:

test
testAser
testHello

@adzialocha adzialocha requested a review from louilinn June 17, 2021 11:17
louilinn
louilinn approved these changes Jun 21, 2021
View reviewed changes
Copy link
Collaborator

@louilinn louilinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this was a request from Lucia? :)

@adzialocha
Copy link
Collaborator Author

adzialocha commented Jun 21, 2021 •
edited
Loading

I assume this was a request from Lucia? :)

Haha, actually that was always annoying me, but maybe Lucia too 😸 Since the search results are limited to 10 in the app you could not find some users at all anymore ..

@adzialocha adzialocha merged commit 09c2372 into main Jun 21, 2021
@adzialocha adzialocha deleted the improve-search branch June 21, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llunaCreixent llunaCreixent llunaCreixent approved these changes

@louilinn louilinn louilinn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adzialocha @louilinn @llunaCreixent