Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user methods: update user data, and get email #130

Merged
merged 15 commits into from
Aug 9, 2022
Merged

Conversation

llunaCreixent
Copy link
Member

@llunaCreixent llunaCreixent commented Jul 25, 2022

  • Create methods: updateUser, and getEmail
  • Create tests
  • Use testing version of dockers
  • Add getEmail method
  • Set dockers back to main in GHActions workflow file, after merging

You can test with the circles-docker branch update-users-feature.

Closes #123

@llunaCreixent llunaCreixent requested a review from JacqueGM as a code owner July 25, 2022 00:08
@llunaCreixent llunaCreixent requested a review from mikozet July 25, 2022 00:08
@llunaCreixent llunaCreixent marked this pull request as draft July 25, 2022 00:19
@llunaCreixent llunaCreixent marked this pull request as ready for review July 25, 2022 10:38
@llunaCreixent
Copy link
Member Author

Tests pass locally for me

@llunaCreixent
Copy link
Member Author

llunaCreixent commented Jul 27, 2022

@mikozet , I've published a testing version (@circles/core@2.12.0-pre-4140b0a), so you can import it to test myxogastria.
Remember to use the new branches for the docker repo, and install the new core package in the myxo repo.

@mikozet
Copy link
Collaborator

mikozet commented Jul 28, 2022

Hi @llunaCreixent
I run tests few times and it looks like they are failing at one point:
Zrzut ekranu 2022-07-28 o 09 24 29

@llunaCreixent
Copy link
Member Author

Hi @llunaCreixent
I run tests few times and it looks like they are failing at one point:
Zrzut ekranu 2022-07-28 o 09 24 29

Then we have to reimplement this test somehow

JacqueGM
JacqueGM previously approved these changes Aug 3, 2022
Copy link
Contributor

@JacqueGM JacqueGM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when version and branches have been updated properly ^^

@llunaCreixent llunaCreixent changed the title Add update user data method Add user methods: update user data, and get email Aug 8, 2022
@llunaCreixent llunaCreixent requested a review from JacqueGM August 8, 2022 12:29
@llunaCreixent llunaCreixent merged commit e838131 into main Aug 9, 2022
@llunaCreixent llunaCreixent deleted the update-users branch August 9, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editing profile utilities
3 participants