Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use latest safe contracts #141

Merged
merged 32 commits into from
Nov 23, 2022
Merged

Use latest safe contracts #141

merged 32 commits into from
Nov 23, 2022

Conversation

llunaCreixent
Copy link
Member

@llunaCreixent llunaCreixent commented Nov 7, 2022 •
edited
Loading

We add the support of the last version of the safe-contracts.

Tasks:

  • Use the GnosisSafeContract and ProxyFactoryContract from @gnosis.pm/safe-contracts by default (i.e. Safe v1.3.0)
  • Create new variables for the addresses of the previous versions of PROXY_FACTORY_ADDRESS_CRC, and SAFE_CONTRACT_ADDRESS_CRC
  • Add SAFE_DEFAULT_CALLBACK_HANDLER
  • Set the correct env addresses for testing according to the deployment with the last version of circles-contracts
  • Add fallbackHandlerAddress in the core constructor
  • Update format data EIP712: add chainId in typeData
  • Add helper method to get the contract instance of a Safe v1.1.1+Circles: getSafeCRCVersionContract()
  • Add method to get the Safe version: core.safe.getVersion
  • Add method to update Safe to the last version (v1.3.0) by changing the the Master Copy: core.safe.updateSafeVersion
  • Add migration test, deploying Safe v1.1.1+Circles for tests
  • Update dependencies
  • Update rollup config
  • Update contributors

Acceptance criteria:

  • Tests passing

Closes #139

llunaCreixent
llunaCreixent commented Nov 8, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
@JacqueGM JacqueGM marked this pull request as ready for review November 22, 2022 09:37
@JacqueGM JacqueGM self-requested a review November 22, 2022 09:37
JacqueGM
JacqueGM previously approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@JacqueGM JacqueGM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@JacqueGM
Copy link
Contributor

JacqueGM commented Nov 23, 2022 •
edited
Loading

Closes #139

@llunaCreixent llunaCreixent merged commit e0fd715 into main Nov 23, 2022
@llunaCreixent llunaCreixent deleted the use-latest-safe-contracts branch November 23, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacqueGM JacqueGM JacqueGM approved these changes

Assignees

@llunaCreixent llunaCreixent

@JacqueGM JacqueGM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migration contracts 1.1.1 to 1.3.0
2 participants
@llunaCreixent @JacqueGM