Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve docker build time #31

Merged
merged 8 commits into from
Mar 18, 2021
Merged

Improve docker build time #31

merged 8 commits into from
Mar 18, 2021

Conversation

adzialocha
Copy link
Collaborator

@adzialocha adzialocha commented Mar 12, 2021 •
edited
Loading

This is MUCH faster 🐎 😀

  • Remove make build step as all images are now pre-built
  • Think of a nice command line API via Makefile to use this with:
    • circles-core
    • circles-api
    • safe-relay-service
  • Make api-worker container wait until the graph is ready (Improve docker setup circles-api#63)

Closes: #29

@adzialocha adzialocha changed the title Improve build speed Improve docker build time Mar 15, 2021
@adzialocha adzialocha mentioned this pull request Mar 16, 2021
Merged
@adzialocha adzialocha marked this pull request as ready for review March 16, 2021 11:36
llunaCreixent
llunaCreixent approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@llunaCreixent llunaCreixent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you @adzialocha :)

@adzialocha adzialocha merged commit 82a0aad into main Mar 18, 2021
@adzialocha adzialocha deleted the improve-build-speed branch March 18, 2021 10:57
@adzialocha adzialocha mentioned this pull request Mar 18, 2021
Closed
@llunaCreixent llunaCreixent mentioned this pull request Jun 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llunaCreixent llunaCreixent llunaCreixent approved these changes

@louilinn louilinn Awaiting requested review from louilinn

Assignees
No one assigned
Labels
enhancement 🎇
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve docker build times
2 participants
@adzialocha @llunaCreixent