Remove console errors on development (#733)

* Remove console errors on development * Fix forward ref error --------- Co-authored-by: Louise Linné <linne.louise@gmail.com>
CirclesUBI · Sep 28, 2023 · 3d7dea6 · 3d7dea6
1 parent 15b151f
commit 3d7dea6
Show file tree

Hide file tree

Showing 8 changed files with 18 additions and 21 deletions.
diff --git a/src/components/ButtonAction.js b/src/components/ButtonAction.js
@@ -59,7 +59,7 @@ const useStyles = makeStyles((theme) => ({
 
 // eslint-disable-next-line react/display-name
 const ButtonAction = React.forwardRef(
-  ({ className, children, disabled, ...props }) => {
+  ({ className, children, disabled, ...props }, ref) => {
     const classes = useStyles();
 
     return (
@@ -70,6 +70,7 @@ const ButtonAction = React.forwardRef(
           disabled: classes.buttonDisabled,
         }}
         disabled={disabled}
+        ref={ref}
         {...props}
       >
         <Box className={classes.buttonContainer}>

diff --git a/src/components/Dialog.js b/src/components/Dialog.js
@@ -37,7 +37,7 @@ const Dialog = ({
         </DialogContentText>
       </DialogContent>
       <DialogActions>
-        <Button autoFocus isPrimary onClick={onConfirm}>
+        <Button autoFocus onClick={onConfirm}>
           {confirmLabel}
         </Button>
         <Button isOutline onClick={onClose}>

diff --git a/src/components/DialogAddMember.js b/src/components/DialogAddMember.js
@@ -29,11 +29,7 @@ const DialogAddMember = ({
       cancelLabel={translate('DialogAddMember.dialogCancel')}
       confirmLabel={confirmLabel}
       open={isOpen}
-      title={
-        <Typography classes={{ root: 'h4_link_white' }} variant="h4">
-          {translate('DialogAddMember.dialogTitle', { username })}
-        </Typography>
-      }
+      title={translate('DialogAddMember.dialogTitle', { username })}
       onClose={handleClose}
       onConfirm={onConfirm}
     >

diff --git a/src/components/DialogPurple.js b/src/components/DialogPurple.js
@@ -1,4 +1,4 @@
-import { Box, Dialog, DialogTitle } from '@mui/material';
+import { Box, Dialog, DialogTitle, Typography } from '@mui/material';
 import makeStyles from '@mui/styles/makeStyles';
 import PropTypes from 'prop-types';
 import React from 'react';
@@ -41,7 +41,13 @@ const DialogPurple = ({
   return (
     <Dialog classes={classes} onClose={onClose} {...otherProps} maxWidth="lg">
       <DialogTitle align="center" classes={titleClasses}>
-        {title}
+        <Typography
+          classes={{ root: 'h4_link_white' }}
+          component="span"
+          variant="h4"
+        >
+          {title}
+        </Typography>
       </DialogTitle>
       {children}
       <Box pb={2} pt={2}>

diff --git a/src/components/DialogTrust.js b/src/components/DialogTrust.js
@@ -78,11 +78,7 @@ const DialogTrust = ({
       confirmLabel={translate('DialogTrust.dialogTrustConfirm')}
       id="trust"
       open={isOpen}
-      title={
-        <Typography classes={{ root: 'h4_link_white' }} variant="h4">
-          {translate('DialogTrust.dialogTrustTitle', { username })}
-        </Typography>
-      }
+      title={translate('DialogTrust.dialogTrustTitle', { username })}
       onClose={handleTrustClose}
       onConfirm={handleTrust}
     >

diff --git a/src/components/DialogTrustRevoke.js b/src/components/DialogTrustRevoke.js
@@ -76,11 +76,9 @@ const DialogTrustRevoke = ({
       confirmLabel={translate('DialogTrustRevoke.dialogRevokeTrustConfirm')}
       id="revoke-trust"
       open={isOpen}
-      title={
-        <Typography classes={{ root: 'h4_link_white' }} variant="h4">
-          {translate('DialogTrustRevoke.dialogRevokeTrustTitle', { username })}
-        </Typography>
-      }
+      title={translate('DialogTrustRevoke.dialogRevokeTrustTitle', {
+        username,
+      })}
       onClose={handleRevokeTrustClose}
       onConfirm={handleRevokeTrust}
     >

diff --git a/src/views/QRGenerator.js b/src/views/QRGenerator.js
@@ -115,7 +115,7 @@ const QRGenerator = () => {
             </ButtonShare>
           </Box>
           <Box mb={1} mt={2}>
-            <Button autoFocus fullWidth isPrimary onClick={handleHideQR}>
+            <Button autoFocus fullWidth onClick={handleHideQR}>
               {translate('QRGenerator.dialogClose')}
             </Button>
           </Box>

diff --git a/src/views/Validation.js b/src/views/Validation.js
@@ -101,7 +101,7 @@ const Validation = () => {
 
   const dialogContentFooter = () => {
     return (
-      <ButtonShare fullWidth isPrimary text={shareText} url={shareLink}>
+      <ButtonShare fullWidth text={shareText} url={shareLink}>
         {translate('Validation.buttonShareProfileLink')}
       </ButtonShare>
     );