-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add export statement for personal wallet #737
Conversation
✅ Deploy Preview for preview-review-circles-garden ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏿
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed :)
Merge pending for Lucia's acceptance
src/utils/fileExports.js
Outdated
data.name = 'CirclesUBI'; | ||
data.paymentNote = 'UBI payout'; | ||
data.name = translate('ExportStatement.exportDataName'); | ||
data.paymentNote = translate('ExportStatement.exportPaymentNote'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now we are adding some text in translations but not all. Maybe then I should add all fields in en.json
src/utils/fileExports.js
Outdated
@@ -203,7 +204,7 @@ export async function downloadCsvStatement( | |||
) { | |||
// Verify date order | |||
if (startDate > endDate) { | |||
throw new Error('Invalid date interval'); | |||
throw new Error(translate('ExportStatement.exportDataName')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was the wrong text so I changed it in a commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏿
47cf009
to
ddeb0af
Compare
* Add export statement for personal wallet * Specify UBI payouts in export for personal wallets * Move all statement file text to en.json --------- Co-authored-by: Louise Linné <linne.louise@gmail.com>
Currently build on:
https://preview-dev.circles.garden/activities