Fix unicode conversion truncation bug (1.3.1) #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The in_iconv_u16() function resolves "alignment" issues where the length of the input string is not mod(4). The solution trims the extra bytes off the input string. If the input string is total less than 4 bytes, then those extra bytes are put in a 4-byte array and are converted. However, if the input string is longer, then those extra bytes are lost. This fix saves the extra "unaligned" bytes in the 4-byte array and converts them afterwards so we don't accidentally lose 1 to 2 characters.
mtremer
pushed a commit
to ipfire/ipfire-2.x
that referenced
this pull request
Sep 3, 2024
- Update from version 1.3.0 to 1.3.1
- Update of rootfile not required
- As we can not upgrade currently to version 1.4.0 due to the rust/ruby issue we need to
update to 1.3.1 as it has a CVE fix in it.
- There are three rust dependencies that have been updated but all have a rust-1.57
requirement so have no problem with our current rust-1.67.0 version
- Changelog
1.3.1
This is a critical patch release with the following fixes:
- [CVE-2024-20380](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-20380):
Fixed a possible crash in the HTML file parser that could cause a
denial-of-service (DoS) condition.
This issue affects version 1.3.0 only and does not affect prior versions.
- [GitHub pull request](Cisco-Talos/clamav#1242)
- Updated select Rust dependencies to the latest versions.
This resolved Cargo audit complaints and included PNG parser bug fixes.
- [GitHub pull request](Cisco-Talos/clamav#1227)
- Fixed a bug causing some text to be truncated when converting from UTF-16.
- [GitHub pull request](Cisco-Talos/clamav#1230)
- Fixed assorted complaints identified by Coverity static analysis.
- [GitHub pull request](Cisco-Talos/clamav#1235)
- Fixed a bug causing CVDs downloaded by the `DatabaseCustomURL` Freshclam
config option to be pruned and then re-downloaded with every update.
- [GitHub pull request](Cisco-Talos/clamav#1238)
- Added the new 'valhalla' database name to the list of optional databases in
preparation for future work.
- [GitHub pull request](Cisco-Talos/clamav#1238)
- Added symbols to the `libclamav.map` file to enable additional build
configurations.
- [GitHub pull request](Cisco-Talos/clamav#1244)
Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #1220
The in_iconv_u16() function resolves "alignment" issues where the length of the input string is not mod(4). The solution trims the extra bytes off the input string. If the input string is total less than 4 bytes, then those extra bytes are put in a 4-byte array and are converted. However, if the input string is longer, then those extra bytes are lost.
This fix saves the extra "unaligned" bytes in the 4-byte array and converts them afterwards so we don't accidentally lose 1 to 2 characters.