Clam 1693: fix integer overflow/undefined behavior in NSIS parser #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
val-ms
requested changes
May 17, 2022
ragusaa
force-pushed
the
CLAM-1693-UndefinedBehavior
branch
2 times, most recently
from
a1a6c8a to
c372bc0
Compare
val-ms
changed the title
val-ms
force-pushed
the
CLAM-1693-UndefinedBehavior
branch
from
c372bc0 to
9a039b4
Compare
|
Rebased to pick up other fixes and see it go through the pipelines. |
Cast int32_t to uint32_t for comparison with uint32_t, to prevent integer overflow, as well as signed/unsigned compare warning.
val-ms
force-pushed
the
CLAM-1693-UndefinedBehavior
branch
from
9a039b4 to
3c77587
Compare
val-ms
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=44493