Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment libclamav SO version (11.0.0 instead of 9.2.0) #778

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

val-ms
Copy link
Contributor

@val-ms val-ms commented Nov 22, 2022

The libclamav SO ABI has changed since 0.103 due to:

Ref: #775

As such, it seems fair to increase the SO version. This is an amendment to this prior change for the ClamAV 1.0.0 version bump:
0dd6ab3

Instead of incrementing SO Current version to 11, and Age to 2, we'll increment SO Current version to 11, and reset Age to 0.

So the SO version will effectively go from:
9.1.0
to:
11.0.0

The libclamav SO ABI has changed since 0.103 due to:
- Removal of the CLAMAV_PUBLIC namespace by no longer using libclamav.map
- Change of: extern const char *cl_strerror(int clerror);
  To: extern const char *cl_strerror(cl_error_t clerror);
  See: https://github.com/micahsnyder/clamav-micah/blob/e66c00f41c9b620a0f2ef67ae359c07049ace52f/libclamav/clamav.h#L1203
- Introduction of Rust symbols to namespace.

Ref: Cisco-Talos#775

As such, it seems fair to increase the SO version.
This is an amendment to this prior change for the ClamAV 1.0.0
version bump:
Cisco-Talos@0dd6ab3

Instead of incrementing SO Current version to 11, and Age to 2,
we'll increment SO Current version to 11, and reset Age to 0.

So the SO version will effectively go from:
  9.1.0
to:
  11.0.0
@val-ms val-ms merged commit 2084e63 into Cisco-Talos:main Nov 23, 2022
@val-ms val-ms deleted the CLAM-1933-bump-SO-version branch November 23, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants