Avoid altering signature for .cargo/vendor files #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the published tarballs contain This change is overwriting that policy for the content of |
micahsnyder
requested changes
Mar 7, 2023
When using the content of the `clamav` tarball in a git repository to version a debian or RedHat package for example. We should never alter the files from cargo or this result in corrupted signature and thus we cannot install the files. As the repo provides its own `.gitattributes` we cannot easily overwrite it without manually updating `.git/info/attributes`. Alternatively we could remove the `.gitattributes` file from the tarball when generating it.
|
I ve resubmitted using your suggestion |
micahsnyder
approved these changes
Mar 9, 2023
micahsnyder
added
the
🍒cherry-pick-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the content of the
clamavtarball in a git repository to version a debian or RedHat package for example. We should never alter the files from cargo or this result in corrupted signature and thus we cannot install the files.As the repo provides its own
.gitattributeswe cannot easily overwrite it without manually updating.git/info/attributes.Alternatively we could remove the
.gitattributesfile from the tarball when generating it.