Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issue in oss-fuzz environment (1.0.2) #996

Merged

Conversation

val-ms
Copy link
Contributor

@val-ms val-ms commented Aug 11, 2023

There is an error building clam with the rust nightly compiler:

error[E0635]: unknown feature proc_macro_span_shrink
--> /rust/registry/src/index.crates.io-6f17d22bba15001f/proc-macro2-1.0.56/src/lib.rs:92:30
|
92 | feature(proc_macro_span, proc_macro_span_shrink)
| ^^^^^^^^^^^^^^^^^^^^^^

We need this to work because oss-fuzz is apparently using rust nightly in their image.

Bumping the proc-macro2 crate version in Cargo.lock resolves the error.

val-ms added 2 commits August 10, 2023 17:48
There is an error building clam with the rust nightly compiler:

error[E0635]: unknown feature `proc_macro_span_shrink`
  --> /rust/registry/src/index.crates.io-6f17d22bba15001f/proc-macro2-1.0.56/src/lib.rs:92:30
   |
92 |     feature(proc_macro_span, proc_macro_span_shrink)
   |                              ^^^^^^^^^^^^^^^^^^^^^^

We need this to work because oss-fuzz is apparently using rust nightly
in their image.

Bumping the proc-macro2 crate version in Cargo.lock resolves the error.
@val-ms
Copy link
Contributor Author

val-ms commented Aug 11, 2023

Just confirmed this doesn't change the minimum supported rust version. It is still 1.61.0.

@val-ms
Copy link
Contributor Author

val-ms commented Aug 11, 2023

fuzz-regression pipeline looking good again.

@val-ms val-ms merged commit b71cc0f into Cisco-Talos:dev/1.0.2 Aug 11, 2023
@val-ms val-ms deleted the oss-fuzz-nightly-build-issue-proc-macro2 branch August 11, 2023 21:30
@val-ms val-ms changed the title Fix build issue in oss-fuzz environment Fix build issue in oss-fuzz environment (1.0.2) Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant