Retries for _query_cvd_version_dns. Fixes #49. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahsnyder
approved these changes
May 19, 2023
There was a problem hiding this comment.
Sorry it took so long to review this. I didn't have notifications enabled for this repo for a long time. So embarrassing!
Anyways, it reads well and appears to work well in local testing. I like it! Thanks @backbord
|
@micahsnyder, no problem at all. Do you think that this change could be released? The latest release 1.1.1 is from 2022-07-28. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @micahsnyder,
I recently noticed that the
_query_dns_txt_entry()might fail from time to time and that there are no retries, so I created #49.Here's a small PR that hopefully fixes the issue.
Would you be so kind and have a look if it's suitable for your project?
Thanks,
Tim