fix: Correct vPC member side (DCNE-93) #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinross
requested review from
lhercot,
shrsr,
anvitha-jain,
sajagana,
samiib and
gmicol
akinross
force-pushed
the
fix/vpc_member_fix
branch
from
9dc36a6
to
a55c799
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #663 +/- ##
===========================================
- Coverage 58.46% 35.75% -22.72%
===========================================
Files 269 266 -3
Lines 12352 12165 -187
Branches 1862 1837 -25
===========================================
- Hits 7222 4349 -2873
- Misses 5002 7816 +2814
+ Partials 128 0 -128
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
samiib
requested changes
Jun 12, 2024
github-actions
bot
changed the title
|
@timcragg Hi Tim, just wondering if you are still working on this one or if you have had a chance to look at the PR review comment? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor bugfix - the l3extMember object uses side instead of name to build the DN, so the module should configure the side attribute instead of the name (I believe the name attribute is left as null if you build an l3extMember object through the APIC GUI).
Closes DCNE-93