-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not suited for Java's modular world #1
Comments
Good catch, and thanks for the feedback! |
Added a note to README.md re JPMS support and jtapi.jar |
Thank you for your response and the offered workaround. |
Deleting It is used by CiscoJtapiPeer peer = (CiscoJtapiPeer) JtapiPeerFactory.getJtapiPeer(null); If I read the code correctly, will return a new instance of So I believe that deleting The following line works exactly the same, CiscoJtapiPeer peer = (CiscoJtapiPeer) JtapiPeerFactory.getJtapiPeer("com.cisco.jtapi.CiscoJtapiPeerImpl"); |
FYI JPMS support is known to be part of the scoping for enhancing JTAPI in support of Java 1.8+ generally (in a yet-unidentified CUCM release.) |
That's awesome! BTW I was able to get this working, and it's sweeeetttt! 🔥 If anyone bumps into this, these were the pitfalls, from the jar point of view:
These ☝️, were handled manually, and need to be repeated if the jar will ever be replaced in my project, e.g. when bumping versions. The following 👇, however, can be handled manually, or in build time.
From a build point of view, it was a bit tricky. To accomplish this in build time, basically, one needs to create the new modular jar and add it to the modulepath. The tricky part is that the original jar, is on the classpath, that's where the modulepath gets it from to begin with. |
Note, new enhancement issue tracking id: CSCvw64751 |
Hello
I wouldn't necessarily call this an issue, or even a question.
And it's not directly related to this repository,
It's more of a
jtapi
codebase issue,but maybe it's worth mentioning in this repo's README.
The
jtapi
jar cannot be used in aJPMS
project.You can easily get away with the lack of
module-info
using the moditect plugin.But the two package-less classes residing in the jar's root:
Afaik, are a no-go in
Java
's modular world.I'm going to have to rebuild my current project in a non
JPMS
manner.Maybe it's worth mentioning in the README that these samples,
or even the
jtapi
jar itself, is not suitable for a modular project.Thank you.
The text was updated successfully, but these errors were encountered: