Skip to content

Commit

Permalink
[ignore] Use dependency in failing test to avoid data race condition.
Browse files Browse the repository at this point in the history
  • Loading branch information
samiib committed May 22, 2024
1 parent f118801 commit 8065077
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,7 @@ jobs:
terraform_version: '1.7.*'
terraform_wrapper: false
- name: Terraform Acceptance Test (APIC ${{ matrix.apic_host.name }})
# TODO: Fix TestAccAciRestManaged_importWithIpv6 to resolve data race failures occurring in the CI
# https://github.com/CiscoDevNet/terraform-provider-aci/issues/1218
run: go test github.com/CiscoDevNet/terraform-provider-aci/v2/internal/provider -v -race -timeout 300m -coverprofile=coverage.out -covermode=atomic -skip TestAccAciRestManaged_importWithIpv6
run: go test github.com/CiscoDevNet/terraform-provider-aci/v2/internal/provider -v -race -timeout 300m -coverprofile=coverage.out -covermode=atomic
env:
TF_ACC: '1'
TF_ACC_STATE_LINEAGE: '1'
Expand Down
6 changes: 6 additions & 0 deletions internal/provider/resource_aci_rest_managed_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -909,6 +909,12 @@ func testAccAciRestManagedConfig_importWithIpv6(name string, resource string, ip
}
resource "aci_rest_managed" "bd_%[2]s_2" {
# TODO: Fix TestAccAciRestManaged_importWithIpv6 to resolve data race failures occurring in the CI
# Remove this dependency when fixed.
# https://github.com/CiscoDevNet/terraform-provider-aci/issues/1218
depends_on = [
aci_rest_managed.bd_%[2]s
]
dn = "${aci_rest_managed.tenant_%[2]s.id}/BD-%[1]s_2"
class_name = "fvBD"
content = {
Expand Down

0 comments on commit 8065077

Please sign in to comment.