Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated aci_l3out_provider_label resource and data-source files #1200

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

sajagana
Copy link
Collaborator

@sajagana sajagana commented Apr 15, 2024

Note:

PR includes the changes of L3Out Fallback Route Group PR changes: #1195

Generated aci_l3out_provider_label resource and data-source files and updated templates to accept parent_dependency_name from properties.yaml file.

akinross
akinross previously approved these changes Apr 16, 2024
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anvitha-jain
anvitha-jain previously approved these changes Apr 18, 2024
@sajagana sajagana changed the base branch from master to floating_svi_modifications April 18, 2024 17:28
@sajagana sajagana changed the base branch from floating_svi_modifications to master April 18, 2024 17:29
@sajagana sajagana dismissed stale reviews from anvitha-jain and akinross April 18, 2024 17:29

The base branch was changed.

…ource files and updated templates to accept parent_dependency_name from properties.yaml file
gen/definitions/properties.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit d70a0cf into CiscoDevNet:master Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Add resource and datasource to support l3extProvLbl
7 participants