Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added relation_to_instance_profile and relation_to_route_control_profile - resource and data-source files (DCNE-153) #1204

Closed

Conversation

sajagana
Copy link
Collaborator

No description provided.

@sajagana sajagana marked this pull request as draft April 24, 2024 17:12
@sajagana sajagana force-pushed the 1170_l3out_instance_profile_new branch from a5b060b to bc57c5c Compare April 25, 2024 03:08
@sajagana sajagana changed the title Added relation_to_instance_profile resource and data-source files Added relation_to_instance_profile and relation_to_route_control_profile - resource and data-source files Apr 25, 2024
@sajagana sajagana marked this pull request as ready for review April 25, 2024 03:15
gmicol
gmicol previously approved these changes Apr 30, 2024
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/data-sources/relation_to_instance_profile.md Outdated Show resolved Hide resolved
docs/data-sources/relation_to_instance_profile.md Outdated Show resolved Hide resolved
docs/data-sources/relation_to_route_control_profile.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a fail test for relation_to_route_control_profile data source. Do you have this error happening locally or is it a CI issue?
Error: Failed to read aci_relation_to_route_control_profile data source

@samiib
Copy link
Collaborator

samiib commented May 14, 2024

There is a fail test for relation_to_route_control_profile data source. Do you have this error happening locally or is it a CI issue? Error: Failed to read aci_relation_to_route_control_profile data source

I think this is a new test that is consistently failing. I re-ran the CI and its correctly picking up the failed test. Unless there is some environment difference because the CI is run on Ubuntu latest.

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2024

Codecov Report

Attention: Patch coverage is 88.53616% with 130 lines in your changes are missing coverage. Please review.

Project coverage is 87.16%. Comparing base (6f45104) to head (eb2a16b).

Files Patch % Lines
...vider/resource_aci_relation_to_instance_profile.go 85.15% 35 Missing and 18 partials ⚠️
.../resource_aci_relation_to_route_control_profile.go 85.75% 35 Missing and 18 partials ⚠️
...er/data_source_aci_relation_to_instance_profile.go 91.30% 6 Missing and 2 partials ⚠️
...ta_source_aci_relation_to_route_control_profile.go 91.66% 6 Missing and 2 partials ⚠️
...rnal/provider/resource_aci_l3out_consumer_label.go 95.48% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1204      +/-   ##
==========================================
+ Coverage   87.03%   87.16%   +0.13%     
==========================================
  Files          43       47       +4     
  Lines       11223    12353    +1130     
==========================================
+ Hits         9768    10768    +1000     
- Misses        991     1077      +86     
- Partials      464      508      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sajagana sajagana requested a review from gmicol May 15, 2024 10:36
@sajagana sajagana force-pushed the 1170_l3out_instance_profile_new branch from a863a75 to eb2a16b Compare May 18, 2024 05:00
…ml file and added logic to exclude resource creation in the generator.go
Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In most examples, the parent resource is missing, could you please add them either as a resource or datasource

@anvitha-jain anvitha-jain self-requested a review May 31, 2024 15:09
@samiib samiib changed the title Added relation_to_instance_profile and relation_to_route_control_profile - resource and data-source files Added relation_to_instance_profile and relation_to_route_control_profile - resource and data-source files (DCNE-153) Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants