Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added aci_l3out_node_sid_profile resource and data-source files #1207

Merged
merged 3 commits into from
May 17, 2024
Merged

Added aci_l3out_node_sid_profile resource and data-source files #1207

merged 3 commits into from
May 17, 2024

Conversation

sajagana
Copy link
Collaborator

No description provided.

@sajagana sajagana linked an issue Apr 29, 2024 that may be closed by this pull request
Enhancement: Add resource and datasource to support mplsNodeSidP #1175
Closed
samiib
samiib requested changes Apr 29, 2024
View reviewed changes
docs/data-sources/tag.md Outdated Show resolved Hide resolved
@samiib samiib self-requested a review April 30, 2024 05:38
samiib
samiib previously approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

gmicol
gmicol previously approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akinross
akinross requested changes May 6, 2024
View reviewed changes
docs/data-sources/l3out_node_sid_profile.md Outdated Show resolved Hide resolved
docs/data-sources/l3out_node_sid_profile.md Outdated Show resolved Hide resolved
@sajagana sajagana dismissed stale reviews from gmicol and samiib via 44c00e0 May 6, 2024 15:46
akinross
akinross reviewed May 7, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you rebase to make CI pass

@sajagana sajagana requested a review from akinross May 7, 2024 07:28
akinross
akinross previously approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib previously approved these changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol
gmicol previously approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr previously approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sajagana sajagana dismissed stale reviews from shrsr and gmicol via 5eaade7 May 17, 2024 14:37
@sajagana sajagana dismissed stale reviews from samiib and akinross via 5eaade7 May 17, 2024 14:37
lhercot
lhercot approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 6f45104 into CiscoDevNet:master May 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhercot lhercot lhercot approved these changes

@anvitha-jain anvitha-jain anvitha-jain approved these changes

@shrsr shrsr shrsr left review comments

@akinross akinross akinross left review comments

@samiib samiib samiib left review comments

@gmicol gmicol gmicol left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: Add resource and datasource to support mplsNodeSidP
7 participants
@sajagana @lhercot @shrsr @akinross @anvitha-jain @samiib @gmicol