[bugfix] Prevent error by setting flood_on_encap and prio for aci_end… #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinross
requested review from
lhercot,
shrsr,
anvitha-jain,
sajagana,
samiib and
gmicol
samiib
reviewed
May 3, 2024
Officially no, but did not want to create changes to the schema since we will be making those changes anyway soon when we are working on the migrate of the resource. But since @sajagana was also asking the same I will add the change. |
akinross
force-pushed
the
error_for_setting_not_specified_attributes_esg
branch
from
cfe05c2
to
b0d4db8
Compare
anvitha-jain
requested changes
May 6, 2024
| if EPg is part of a group that does not | ||
| a contract for communication. | ||
| * `prio` - (Optional) The QoS priority class identifier. | ||
| * `annotation` - (Read-Only) Annotation of object Endpoint Security Group. |
| a contract for communication. | ||
| * `prio` - (Optional) The QoS priority class identifier. | ||
| * `annotation` - (Read-Only) Annotation of object Endpoint Security Group. | ||
| * `description` - (Read-Only) Description of object Endpoint Security Group. |
| * `prio` - (Optional) The QoS priority class identifier. | ||
| * `annotation` - (Read-Only) Annotation of object Endpoint Security Group. | ||
| * `description` - (Read-Only) Description of object Endpoint Security Group. | ||
| * `name_alias` - (Read-Only) Name Alias of object Endpoint Security Group. |
| * `name_alias` - (Read-Only) Name Alias of object Endpoint Security Group. | ||
| * `match_t` - (Read-Only) The provider label match criteria. | ||
| * `pc_enf_pref` - (Read-Only) The preferred policy control. | ||
| * `pref_gr_memb` - (Read-Only) Represents parameter used to determine if EPg is part of a group that does not a contract for communication. |
| @@ -32,18 +32,14 @@ data "aci_endpoint_security_group" "example" { | |||
| ## Argument Reference ## | |||
|
|
|||
| * `application_profile_dn` - (Required) Distinguished name of parent Application Profile object. | |||
| * `name` - (Required) name of object Endpoint Security Group. | |||
| * `name` - (Required) Name of object Endpoint Security Group. | |||
Comment on lines
40
to
42
| * `annotation` - (Read-Only) Annotation of object Endpoint Security Group. | ||
| * `description` - (Read-Only) Description of object Endpoint Security Group. | ||
| * `name_alias` - (Read-Only) Name Alias of object Endpoint Security Group. |
| * `name_alias` - (Read-Only) Name Alias of object Endpoint Security Group. | ||
| * `match_t` - (Read-Only) The provider label match criteria. | ||
| * `pc_enf_pref` - (Read-Only) The preferred policy control. | ||
| * `pref_gr_memb` - (Read-Only) Represents parameter used to determine if EPg is part of a group that does not a contract for communication. |
akinross
force-pushed
the
error_for_setting_not_specified_attributes_esg
branch
from
b0d4db8
to
bc3ac16
Compare
…point_security_group
…the non required attributes to read-only in aci_endpoint_security datasource
akinross
force-pushed
the
error_for_setting_not_specified_attributes_esg
branch
from
bc3ac16
to
6f03369
Compare
gmicol
approved these changes
May 9, 2024
anvitha-jain
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…point_security_group
In f305774
flood_on_encapandpriowere removed from schema however in the import/create/update these values were still set.Which led to the following error:
│ Error: Plugin did not respond
│
│ The plugin encountered an error, and failed to respond to the plugin6.(*GRPCProvider).ImportResourceState call. The plugin
│ logs may contain more details.
╵
Stack trace from the terraform-provider-aci plugin:
panic: Invalid address to set: []string{"prio"}
Cleaning up the attributes setting from the functions cleaned up the error.