Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Resource and Datasource for Netflow Record Policy #1220

Merged
merged 8 commits into from
Jun 25, 2024
Merged

Add Resource and Datasource for Netflow Record Policy #1220

merged 8 commits into from
Jun 25, 2024

Conversation

gmicol
Copy link
Collaborator

@gmicol gmicol commented May 23, 2024

Resolves #1210

@gmicol gmicol self-assigned this May 23, 2024
akinross
akinross requested changes Jun 10, 2024
View reviewed changes
docs/data-sources/netflow_record_policy.md Outdated Show resolved Hide resolved
docs/data-sources/netflow_record_policy.md Outdated Show resolved Hide resolved
docs/data-sources/netflow_record_policy.md Outdated Show resolved Hide resolved
docs/data-sources/netflow_record_policy.md Outdated Show resolved Hide resolved
docs/resources/netflow_record_policy.md Show resolved Hide resolved
@gmicol gmicol requested a review from akinross June 13, 2024 17:39
akinross
akinross previously approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr requested changes Jun 17, 2024
View reviewed changes
gen/templates/resource_test.go.tmpl Outdated Show resolved Hide resolved
gen/templates/testvars.yaml.tmpl Outdated Show resolved Hide resolved
@gmicol gmicol requested review from akinross and shrsr June 17, 2024 17:27
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 88.25561% with 68 lines in your changes missing coverage. Please review.

Project coverage is 87.09%. Comparing base (5f5cc63) to head (ed80520).

Files Patch % Lines
...nal/provider/resource_aci_netflow_record_policy.go 87.30% 37 Missing and 21 partials ⚠️
.../provider/data_source_aci_netflow_record_policy.go 91.66% 7 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1220      +/-   ##
==========================================
+ Coverage   87.03%   87.09%   +0.05%     
==========================================
  Files          43       45       +2     
  Lines       11223    11802     +579     
==========================================
+ Hits         9768    10279     +511     
- Misses        991     1035      +44     
- Partials      464      488      +24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shrsr
shrsr previously approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib previously approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

akinross
akinross previously approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anvitha-jain
anvitha-jain previously approved these changes Jun 18, 2024
View reviewed changes
lhercot
lhercot requested changes Jun 19, 2024
View reviewed changes
docs/resources/netflow_record_policy.md Outdated Show resolved Hide resolved
gen/definitions/properties.yaml Outdated Show resolved Hide resolved
gen/definitions/properties.yaml Outdated Show resolved Hide resolved
@gmicol gmicol dismissed stale reviews from anvitha-jain, akinross, samiib, and shrsr via 69e6f0f June 20, 2024 16:58
@gmicol gmicol requested a review from lhercot June 20, 2024 16:58
samiib
samiib approved these changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shrsr shrsr self-requested a review June 21, 2024 12:58
shrsr
shrsr approved these changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akinross
akinross approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lhercot
lhercot approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 2d8ffe2 into CiscoDevNet:master Jun 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhercot lhercot lhercot approved these changes

@shrsr shrsr shrsr approved these changes

@akinross akinross akinross approved these changes

@anvitha-jain anvitha-jain anvitha-jain approved these changes

@samiib samiib samiib approved these changes

@sajagana sajagana Awaiting requested review from sajagana

Assignees

@gmicol gmicol

Labels
enhancement new-data-source new-resource
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Resource and Datasource for netflowRecordPol.
7 participants
@gmicol @codecov-commenter @lhercot @shrsr @akinross @anvitha-jain @samiib