Aci resource migration esg #1223

akinross · 2024-05-29T12:09:26Z

fixes #1157

gen/definitions/classes.yaml

sajagana

LGMT!

samiib

Just have question about that json file.

samiib · 2024-06-12T11:36:41Z

gen/definitions/schema-git-commit-e21fb3e5.json

What's this file for?

The file contains an overview of the provider schema retrieved with: terraform providers schema -json | jq > schema-doc-new.json. This is used read old the old attribute types/name, which need to be migrated. This way we do not have to manually input all this information into definition files.

I have added the commit tag in case we ever want to look back, or generate a new file.

Is that generation part of the go generate process?

No this is a static file, if we would regenerate on every provider update the problem would be that the old schema used for migration is lost and thus the mapping would not work. So the assumption is a snapshot in time in which we do not make changes anymore to schema of existing resources, where if something needs to be adjusted we would migrate it to framework.

codecov-commenter · 2024-06-14T14:35:25Z

Codecov Report

Attention: Patch coverage is 93.77778% with 56 lines in your changes missing coverage. Please review.

Project coverage is 85.08%. Comparing base (e32ebc3) to head (f1d8900).
Report is 1 commits behind head on master.

Files	Patch %	Lines
...rovider/data_source_aci_endpoint_security_group.go	97.45%	6 Missing and 2 partials ⚠️
...r/data_source_aci_relation_to_consumed_contract.go	91.66%	6 Missing and 2 partials ⚠️
...der/data_source_aci_relation_to_contract_master.go	91.30%	6 Missing and 2 partials ⚠️
...r/data_source_aci_relation_to_imported_contract.go	91.66%	6 Missing and 2 partials ⚠️
.../data_source_aci_relation_to_intra_epg_contract.go	91.30%	6 Missing and 2 partials ⚠️
...r/data_source_aci_relation_to_provided_contract.go	92.00%	6 Missing and 2 partials ⚠️
...ider/data_source_aci_relation_to_taboo_contract.go	91.30%	6 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1223      +/-   ##
==========================================
- Coverage   87.09%   85.08%   -2.02%     
==========================================
  Files          45       59      +14     
  Lines       11802    16619    +4817     
==========================================
+ Hits        10279    14140    +3861     
- Misses       1035     1802     +767     
- Partials      488      677     +189

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

samiib

LGTM!

shrsr · 2024-06-18T14:43:23Z

gen/definitions/classes.yaml

@@ -20,6 +23,7 @@ vzCPIf:
 rtctrlProfile:
  resource_name: "route_control_profile"
  rn_format: "/prof-{name}"
+  exclude: true


Why is exclude used here? Did we introduce the ability to not generate resources if exclude is set to true in the generator and its meta is included?

shrsr · 2024-06-18T14:48:02Z

docs/resources/endpoint_security_group.md

+    {
+      annotation              = "annotation_1"
+      priority                = "level1"
+      contract_interface_name = aci_contract_interface.example.name


I don't think we have a resource aci_contract_interface? Is this the right value?

…urce

…a esg isolation

…es in class definition file

samiib

I think it should be Networking in the UI location.

samiib · 2024-07-02T12:46:23Z

gen/definitions/classes.yaml

+    - "Tenants -> Networkings -> L3Outs -> External EPGs -> Contracts"
+    - "Tenants -> Networkings -> L2Outs -> External EPGs -> Contracts"


Suggested change

- "Tenants -> Networkings -> L3Outs -> External EPGs -> Contracts"

- "Tenants -> Networkings -> L2Outs -> External EPGs -> Contracts"

- "Tenants -> Networking -> L3Outs -> External EPGs -> Contracts"

- "Tenants -> Networking -> L2Outs -> External EPGs -> Contracts"

samiib · 2024-07-02T12:46:39Z

gen/definitions/classes.yaml

+    - "Tenants -> Networkings -> L3Outs -> External EPGs -> Contracts"
+    - "Tenants -> Networkings -> L2Outs -> External EPGs -> Contracts"


Suggested change

- "Tenants -> Networkings -> L3Outs -> External EPGs -> Contracts"

- "Tenants -> Networkings -> L2Outs -> External EPGs -> Contracts"

- "Tenants -> Networking -> L3Outs -> External EPGs -> Contracts"

- "Tenants -> Networking -> L2Outs -> External EPGs -> Contracts"

samiib · 2024-07-02T12:46:53Z

gen/definitions/classes.yaml

+    - "Tenants -> Networkings -> L3Outs -> External EPGs -> Contracts"
+    - "Tenants -> Networkings -> L2Outs -> External EPGs -> Contracts"


Suggested change

- "Tenants -> Networkings -> L3Outs -> External EPGs -> Contracts"

- "Tenants -> Networkings -> L2Outs -> External EPGs -> Contracts"

- "Tenants -> Networking -> L3Outs -> External EPGs -> Contracts"

- "Tenants -> Networking -> L2Outs -> External EPGs -> Contracts"

samiib · 2024-07-02T12:48:17Z

gen/definitions/classes.yaml

+    - "Tenants -> Networkings -> L3Outs -> External EPGs -> Contracts"
+    - "Tenants -> Networkings -> L2Outs -> External EPGs -> Contracts"


Suggested change

- "Tenants -> Networkings -> L3Outs -> External EPGs -> Contracts"

- "Tenants -> Networkings -> L2Outs -> External EPGs -> Contracts"

- "Tenants -> Networking -> L3Outs -> External EPGs -> Contracts"

- "Tenants -> Networking -> L2Outs -> External EPGs -> Contracts"

samiib · 2024-07-02T12:48:35Z

gen/definitions/classes.yaml

+  ui_locations:
+    - "Tenants -> Application Profiles -> Application EPGs -> Contracts"
+    - "Tenants -> Application Profiles -> Endpoint Security Groups -> Contracts"
+    - "Tenants -> Networkings -> L3Outs -> External EPGs -> Contracts"


Suggested change

- "Tenants -> Networkings -> L3Outs -> External EPGs -> Contracts"

- "Tenants -> Networking -> L3Outs -> External EPGs -> Contracts"

samiib · 2024-07-02T12:48:51Z

gen/definitions/classes.yaml

+    - "Tenants -> Networkings -> L3Outs -> External EPGs"
+    - "Tenants -> Networkings -> L2Outs -> External EPGs"


Suggested change

- "Tenants -> Networkings -> L3Outs -> External EPGs"

- "Tenants -> Networkings -> L2Outs -> External EPGs"

- "Tenants -> Networking -> L3Outs -> External EPGs"

- "Tenants -> Networking -> L2Outs -> External EPGs"

samiib · 2024-07-02T13:05:05Z

gen/definitions/properties.yaml

@@ -12,14 +12,17 @@ global:
    id: "The identifier of the %s object."
    tnVzOOBBrCPName: "The name of the Out Of Band Contract object."
    tnRtctrlProfileName: "The name of the Route Control Profile object."
+    prio: "The QoS priority class identifierq of the %s object."


Suggested change

prio: "The QoS priority class identifierq of the %s object."

prio: "The QoS priority class identifier of the %s object."

samiib

LGTM

lhercot

LGTM

This was linked to issues May 29, 2024

Create a new resource and data-source for "external_epg_intra_epg_contracts" #936

Closed

Create a new resource and data-source for Taboo Class: "fvRsProtBy" #938

Closed

akinross force-pushed the aci_resource_migration_esg branch 3 times, most recently from db6f3ce to 7bc427f Compare May 30, 2024 09:08

lhercot requested review from sajagana, lhercot, gmicol, shrsr, anvitha-jain, abrahammughal and samiib May 30, 2024 18:10

anvitha-jain previously approved these changes May 31, 2024

View reviewed changes

sajagana requested changes Jun 3, 2024

View reviewed changes

akinross requested a review from sajagana June 3, 2024 13:00

sajagana previously approved these changes Jun 3, 2024

View reviewed changes

samiib requested changes Jun 12, 2024

View reviewed changes

akinross requested a review from samiib June 12, 2024 11:58

akinross force-pushed the aci_resource_migration_esg branch from ce55265 to baeb7b5 Compare June 14, 2024 13:50

samiib previously approved these changes Jun 17, 2024

View reviewed changes

shrsr requested changes Jun 18, 2024

View reviewed changes

akinross dismissed stale reviews from samiib, sajagana, and anvitha-jain via 0fbda53 June 18, 2024 18:05

akinross requested review from shrsr, anvitha-jain, sajagana and samiib June 18, 2024 18:47

akinross added 5 commits July 2, 2024 09:46

[ignore] Rename contract_interface ti existing imported_contract reso…

ff182ae

…urce

[ignore] Remove unneeded log statements

926af49

[ignore] Documentation update for esg preferred group member and intr…

61f6646

…a esg isolation

[ignore] Fix typo in documentation for distinguished in datasources

dda2968

[ignore] Changing variable naming in go generate and fix resource nam…

7d7be7a

…es in class definition file

akinross dismissed stale reviews from samiib, gmicol, and sajagana via 7d7be7a July 2, 2024 07:55

akinross force-pushed the aci_resource_migration_esg branch from 7589916 to 7d7be7a Compare July 2, 2024 07:55

akinross added 4 commits July 2, 2024 10:50

[ignore] Fix examples for target_dns in data-sources

230b9de

[ignore] Fix examples for target_dns in resources

32589bb

[ignore] Add maximum items for children taht only allow 1 entry

72eaf20

[ignore] Fix documentation sentences

7a32fa8

akinross requested review from lhercot, sajagana, samiib and gmicol July 2, 2024 10:10

[ignore] Add dnformats for l2out and l3out to contract_masters

029e524

samiib requested changes Jul 2, 2024

View reviewed changes

[ignore] Change networkings to networking in documentation

9dc0862

akinross requested a review from samiib July 2, 2024 12:58

samiib requested changes Jul 2, 2024

View reviewed changes

[ignore] Fix typo in documentation for QOS priority

a8d4e51

akinross requested a review from samiib July 2, 2024 13:10

samiib previously approved these changes Jul 2, 2024

View reviewed changes

[ignore] Change documentation for attributes

f1d8900

akinross dismissed samiib’s stale review via f1d8900 July 2, 2024 18:25

lhercot approved these changes Jul 2, 2024

View reviewed changes

lhercot merged commit c9b51cd into CiscoDevNet:master Jul 2, 2024
4 checks passed

akinross mentioned this pull request Jul 3, 2024

Create a new resource and data-source for External EPG contracts - Classes: "fvRsProv" "fvRsCons" #1023

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Aci resource migration esg #1223

Aci resource migration esg #1223

akinross commented May 29, 2024

sajagana left a comment

samiib left a comment

samiib Jun 12, 2024

akinross Jun 12, 2024

lhercot Jun 13, 2024

akinross Jun 13, 2024

codecov-commenter commented Jun 14, 2024 •

edited

Loading

samiib left a comment

shrsr Jun 18, 2024

shrsr Jun 18, 2024

samiib left a comment •

edited

Loading

samiib Jul 2, 2024

samiib Jul 2, 2024

samiib Jul 2, 2024

samiib Jul 2, 2024

samiib Jul 2, 2024

samiib Jul 2, 2024

samiib Jul 2, 2024

samiib left a comment

lhercot left a comment

		- "Tenants -> Networkings -> L3Outs -> External EPGs -> Contracts"
		- "Tenants -> Networkings -> L2Outs -> External EPGs -> Contracts"

	- "Tenants -> Networkings -> L3Outs -> External EPGs -> Contracts"
	- "Tenants -> Networking -> L3Outs -> External EPGs -> Contracts"

	prio: "The QoS priority class identifierq of the %s object."
	prio: "The QoS priority class identifier of the %s object."

Aci resource migration esg #1223

Aci resource migration esg #1223

Conversation

akinross commented May 29, 2024

sajagana left a comment

Choose a reason for hiding this comment

samiib left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-commenter commented Jun 14, 2024 • edited Loading

Codecov Report

samiib left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

samiib left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

samiib left a comment

Choose a reason for hiding this comment

lhercot left a comment

Choose a reason for hiding this comment

codecov-commenter commented Jun 14, 2024 •

edited

Loading

samiib left a comment •

edited

Loading