[minor_change] Add datasource and resource for fvFBRoute in aci_vrf_f…

[akinross]

…allback_route and aci_vrf_fallback_route_group

fixes #1185

[akinross]

CI failing because of introduced dependency in main.go, please ignore during review asked @samiib already to have a look

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 90.02890% with 69 lines in your changes missing coverage. Please review.

Project coverage is 85.24%. Comparing base (c9b51cd) to head (170e508).

Files	Patch %	Lines
...ternal/provider/resource_aci_vrf_fallback_route.go	86.51%	35 Missing and 18 partials ⚠️
...nal/provider/data_source_aci_vrf_fallback_route.go	92.30%	6 Missing and 2 partials ⚠️
.../provider/resource_aci_vrf_fallback_route_group.go	93.38%	5 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1227      +/-   ##
==========================================
+ Coverage   85.08%   85.24%   +0.15%     
==========================================
  Files          59       61       +2     
  Lines       16619    17263     +644     
==========================================
+ Hits        14140    14715     +575     
- Misses       1802     1848      +46     
- Partials      677      700      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[samiib]

CI failing because of introduced dependency in main.go, please ignore during review asked @samiib already to have a look

@akinross

I tried adding the new dependency as an import in generator.go to force it to be downloaded to vendor but that wasn't working. See: edfdf7b
import "golang.org/x/tools/cmd/goimports" is a program, not an importable package

I don't see any other way to get this into vendor as it's not really intended to be used to vendor programs. The vendor command will only find packages required to build the provider and other programs are not really required to build it, just generate it.

For now I got around this by adding -mod=mod to the single generate command.

@lhercot - This may be the one exception to having everything in vendor. What do you think?

[sajagana]

LGTM!

[samiib]

CI failing because of introduced dependency in main.go, please ignore during review asked @samiib already to have a look

@akinross

I tried adding the new dependency as an import in generator.go to force it to be downloaded to vendor but that wasn't working. See: edfdf7b import "golang.org/x/tools/cmd/goimports" is a program, not an importable package

I don't see any other way to get this into vendor as it's not really intended to be used to vendor programs. The vendor command will only find packages required to build the provider and other programs are not really required to build it, just generate it.

For now I got around this by adding -mod=mod to the single generate command.

@lhercot - This may be the one exception to having everything in vendor. What do you think?

Thank you @lhercot for suggesting a different method of specifying the tool dependency in the provider.
I committed the change and the vendor files to the PR and this is working well in the CI now.

[samiib]

LGTM

[sajagana]

LGTM!

[samiib]

LGTM

[lhercot]

LGTM

[lhercot]

LGTM