Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated resource and datasource for fvSiteAssociated and fvRemoteId #1233

Open
wants to merge 42 commits into
base: master
Choose a base branch
from
Open

Generated resource and datasource for fvSiteAssociated and fvRemoteId #1233

wants to merge 42 commits into from

Conversation

abrahammughal
Copy link
Collaborator

Fixes #1224

@akinross
Copy link
Collaborator

akinross commented Jun 14, 2024 •
edited
Loading

CI failing on go generate, make sure you run go generate before you push the changes. This ensures that you have not made any manual changes that the go generate command will wipe away.

Please use [ignore] tag for commits that are not related text that need to be in release notes / changes. So Generated resource and datasource for fvSiteAssociated would be a minor_change.
Created fvRemoteId class would be a minor_change. The other would be ignore.

akinross
akinross requested changes Jun 14, 2024
View reviewed changes
internal/provider/test_constants.go Outdated Show resolved Hide resolved
@abrahammughal abrahammughal force-pushed the associated_site_and_remote_id branch 3 times, most recently from 6ba7399 to 279aee2 Compare June 25, 2024 22:59
@abrahammughal abrahammughal force-pushed the associated_site_and_remote_id branch 2 times, most recently from d46c36f to bed4ce3 Compare July 10, 2024 22:46
abmughal and others added 16 commits July 15, 2024 15:14
@abrahammughal
[ignore] testing
8ec7ec0
@abrahammughal
[ignore] minor definition change
a48827d
@abrahammughal
[ignore] Added formatting for pc_tag values
40af25c
@abrahammughal
[ignore] fixed unecessary validators for resource
b5debb9
@abrahammughal
[ignore] removing errCode check
4d16d4a
@abrahammughal
[ignore] trying different test values
998de60
@abrahammughal
[ignore
2fca10e
@abrahammughal
[ignore] deleted binary file
7c51a8c
@abrahammughal
[ignore] ran tidy
1171152
@abrahammughal
[ignore]
32d4b08
@abrahammughal
[ignore] changed examples
2d51bac
@abrahammughal
[ignore] testing
4c4efcd
@abrahammughal
[ignore] testing
b2f2e85
@abrahammughal
[ignore] minor test changes
9cd774a
@abrahammughal
[ignore] changes with rebase
5a99a45
@abrahammughal
[ignore] fixed notexisting datasource test error
cc2d07e
@abrahammughal
[ignore] fixed unclosed brace
0f5dc87
@abrahammughal
[ignore]
f3abf66
@abrahammughal
[ignore] added datasource required attribute
3b7b002
@abrahammughal
[ignore] added required attributes pc_tag and vrf_pc_tag
862c59c
@abrahammughal
[ignore] added modified files
d7be417
@abrahammughal
[ignore] removed remote_vrf_pc_tag as required attribute
c6e94a8
@abrahammughal
[ignore] changed default value for remote_ctx_pc_tag
6a32804
@abrahammughal
[ignore] updated vendor version
a30154e
@abrahammughal
[ignore] ran tidy
bf67ddb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sajagana sajagana Awaiting requested review from sajagana

@lhercot lhercot Awaiting requested review from lhercot

@anvitha-jain anvitha-jain Awaiting requested review from anvitha-jain

@samiib samiib Awaiting requested review from samiib

@gmicol gmicol Awaiting requested review from gmicol

@akinross akinross Awaiting requested review from akinross

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add resource and datasource for fvSiteAssociated and fvRemoteId
2 participants
@abrahammughal @akinross