Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aci-go-client to version 2.28.2 #1236

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

samiib
Copy link
Collaborator

@samiib samiib commented Jun 14, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@0b33a73). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1236   +/-   ##
=========================================
  Coverage          ?   87.03%           
=========================================
  Files             ?       43           
  Lines             ?    11223           
  Branches          ?        0           
=========================================
  Hits              ?     9768           
  Misses            ?      991           
  Partials          ?      464           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 5f5cc63 into CiscoDevNet:master Jun 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test case in aci_rest_managed causing random CI failures
4 participants