Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor_change] Added uSeg Attribute resource and data-source files #1239

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[minor_change] Added uSeg Attribute resource and data-source files #1239

wants to merge 5 commits into from

Conversation

sajagana
Copy link
Collaborator

No description provided.

@sajagana sajagana marked this pull request as ready for review June 21, 2024 11:29
@akinross akinross linked an issue Jun 24, 2024 that may be closed by this pull request
useg epg creation #1221
Open
akinross
akinross requested changes Jun 24, 2024
View reviewed changes
docs/resources/epg_useg_criterion.md Outdated Show resolved Hide resolved
docs/resources/epg_useg_sub_criterion.md Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@sajagana sajagana force-pushed the 1221_useg_criterion branch 2 times, most recently from 36897ae to 692decd Compare June 28, 2024 12:18
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.61222% with 541 lines in your changes missing coverage. Please review.

Project coverage is 84.50%. Comparing base (e45252b) to head (bf2d1cb).

Files Patch % Lines
.../provider/resource_aci_epg_useg_block_statement.go 84.97% 45 Missing and 25 partials ⚠️
...al/provider/resource_aci_epg_useg_dns_attribute.go 84.12% 45 Missing and 25 partials ⚠️
...nal/provider/resource_aci_epg_useg_ip_attribute.go 84.61% 45 Missing and 25 partials ⚠️
...al/provider/resource_aci_epg_useg_mac_attribute.go 84.09% 45 Missing and 25 partials ⚠️
...vider/resource_aci_epg_useg_sub_block_statement.go 84.23% 45 Missing and 25 partials ⚠️
...nal/provider/resource_aci_epg_useg_vm_attribute.go 85.82% 45 Missing and 25 partials ⚠️
...ovider/resource_aci_epg_useg_ad_group_attribute.go 85.26% 43 Missing and 22 partials ⚠️
...der/data_source_aci_epg_useg_ad_group_attribute.go 92.85% 6 Missing and 2 partials ⚠️
...ovider/data_source_aci_epg_useg_block_statement.go 93.33% 6 Missing and 2 partials ⚠️
...provider/data_source_aci_epg_useg_dns_attribute.go 92.85% 6 Missing and 2 partials ⚠️
... and 4 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1239      +/-   ##
==========================================
+ Coverage   84.05%   84.50%   +0.44%     
==========================================
  Files          61       75      +14     
  Lines       17940    21947    +4007     
==========================================
+ Hits        15080    18546    +3466     
- Misses       2054     2409     +355     
- Partials      806      992     +186

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sajagana sajagana requested a review from akinross July 1, 2024 09:20
@sajagana sajagana force-pushed the 1221_useg_criterion branch 2 times, most recently from a6fa8fd to 8cd313a Compare July 3, 2024 13:15
@sajagana sajagana requested a review from akinross July 8, 2024 10:55
akinross
akinross previously approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib previously approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sajagana sajagana dismissed stale reviews from samiib and akinross via bf2d1cb July 9, 2024 16:35
@lhercot lhercot requested a review from samiib July 9, 2024 23:52
samiib
samiib approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anvitha-jain
anvitha-jain requested changes Jul 11, 2024
View reviewed changes
gen/generator.go Show resolved Hide resolved
gmicol
gmicol approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anvitha-jain anvitha-jain anvitha-jain approved these changes

@samiib samiib samiib approved these changes

@gmicol gmicol gmicol approved these changes

@akinross akinross akinross left review comments

@lhercot lhercot Awaiting requested review from lhercot

@shrsr shrsr Awaiting requested review from shrsr

@abrahammughal abrahammughal Awaiting requested review from abrahammughal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useg epg creation
6 participants
@sajagana @codecov-commenter @akinross @anvitha-jain @samiib @gmicol