Add Resource and Datasource for Netflow Exporter Policy (netflowExporterPol) #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmicol
requested review from
lhercot,
shrsr,
akinross,
anvitha-jain,
sajagana and
samiib
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1242 +/- ##
==========================================
+ Coverage 84.05% 84.18% +0.12%
==========================================
Files 61 63 +2
Lines 17940 18591 +651
==========================================
+ Hits 15080 15651 +571
- Misses 2054 2106 +52
- Partials 806 834 +28 ☔ View full report in Codecov by Sentry. |
akinross
requested changes
Jun 28, 2024
| - Default: `CS2` | ||
| - Valid Values: `AF11`, `AF12`, `AF13`, `AF21`, `AF22`, `AF23`, `AF31`, `AF32`, `AF33`, `AF41`, `AF42`, `AF43`, `CS0`, `CS1`, `CS2`, `CS3`, `CS4`, `CS5`, `CS6`, `CS7`, `EF`, `VA`. | ||
| * `dst_addr` (dstAddr) - (string) Remote node destination IP address. | ||
| * `dst_port` (dstPort) - (string) Remote node destination port. |
There was a problem hiding this comment.
Can only the string representation of a port be provided or also a number like http or 80?
gmicol
force-pushed
the
aci_netflow_exporter_pol_updated
branch
from
7fa6460
to
205af18
Compare
gmicol
force-pushed
the
aci_netflow_exporter_pol_updated
branch
from
205af18
to
9e33a48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1211