Aci resource migration epg #1250
Conversation
|
Work in progress to solve EPG part of #1042 |
akinross
force-pushed
the
aci_resource_migration_epg
branch
3 times, most recently
from
e85c01b
to
f9a3794
Compare
akinross
force-pushed
the
aci_resource_migration_epg
branch
from
f9a3794
to
6bf612d
Compare
akinross
force-pushed
the
aci_resource_migration_epg
branch
14 times, most recently
from
3c72394
to
5175463
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1250 +/- ##
==========================================
+ Coverage 84.48% 84.69% +0.21%
==========================================
Files 75 91 +16
Lines 21956 33545 +11589
==========================================
+ Hits 18549 28412 +9863
- Misses 2415 3829 +1414
- Partials 992 1304 +312 ☔ View full report in Codecov by Sentry. |
akinross
force-pushed
the
aci_resource_migration_epg
branch
3 times, most recently
from
9c83557
to
e503698
Compare
akinross
force-pushed
the
aci_resource_migration_epg
branch
3 times, most recently
from
973839a
to
acfcaee
Compare
akinross
force-pushed
the
aci_resource_migration_epg
branch
from
aff2314
to
cbefc5f
Compare
akinross
force-pushed
the
aci_resource_migration_epg
branch
from
cbefc5f
to
c97e512
Compare
| ipamEnabled: "no" | ||
| ignores: | ||
| - "apiMode" | ||
| ignore_properties_in_test: |
There was a problem hiding this comment.
Can we just have the following under ignore_properties_in_test?
ignore_properties_in_test:
- "ipamDhcpOverride"
- "ipamEnabled"
- "ipamGateway"
and..
Include the following in the test values like we usually do?
ipam_dhcp_override : "10.0.0.2"
ipam_enabled: "yes"
ipam_gateway: "10.0.0.1"
There was a problem hiding this comment.
This would do away with the additional complexity in the resource_example templates like having:
{{- else if .IgnoreInTest}}
We would only need .IgnoreInTest in testvars and the the code for ignoreTestProperty() in the generator will only return a bool value.
There was a problem hiding this comment.
The reason why I did like I did is because we use the test values for populating the examples. But since we exclude the values from testing because we do not have the correct version running we cannot do the lookup here. Let me know if you want me to spend time after my holiday to see how to do this differently but think it would require more refactor work.
akinross
dismissed stale reviews from sajagana, anvitha-jain, and samiib
via
3631de8
No description provided.