Removed check to test resource attributes when ImportStateVerify is set to true in resource tests #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tateVerify is set to true in resource tests
shrsr
requested review from
lhercot,
akinross,
anvitha-jain,
sajagana,
samiib and
gmicol
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1265 +/- ##
=======================================
Coverage 84.05% 84.05%
=======================================
Files 61 61
Lines 17940 17940
=======================================
Hits 15080 15080
Misses 2054 2054
Partials 806 806 ☔ View full report in Codecov by Sentry. |
|
Sorry maybe a silly question but just wondering, why we needed to remove the attribute checks when ImportStateVerify is true? |
|
@samiib When ImportStateVerify is set to True, Terraform automatically verifies that the state of the imported resource matches the expected state. |
samiib
approved these changes
Jul 31, 2024
anvitha-jain
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.