[bugfix] Resolves deletion of nodes from controller upon destroy (DCNE-152) #1266

anvitha-jain · 2024-08-06T15:54:40Z

codecov-commenter · 2024-08-06T16:52:49Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.25%. Comparing base (f95173e) to head (df3bc26).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1266   +/-   ##
=======================================
  Coverage   85.25%   85.25%           
=======================================
  Files         102      102           
  Lines       37812    37812           
=======================================
  Hits        32238    32238           
  Misses       4118     4118           
  Partials     1456     1456

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gmicol

need to fix CI failure

aci/resource_aci_fabricnodeidentp.go

docs/data-sources/fabric_node_member.md

aci/resource_aci_fabricnodeidentp.go

samiib

LGTM

aci/resource_aci_fabricnodeidentp.go

samiib

LGTM

shrsr

LGTM

samiib

LGTM

akinross · 2024-09-10T17:30:20Z

aci/data_source_aci_fabricnodeidentp.go

+
+			"commission": &schema.Schema{
+				Type:     schema.TypeString,
+				Optional: true,


Ok but this is not part of the DN right? In what scenario would this be provided by a user when it gets read and set in the getAndsetDecommissionedNodes function?

Changed

docs/data-sources/fabric_node_member.md

docs/resources/fabric_node_member.md

docs/data-sources/fabric_node_member.md

…ed but not removed from controller).

…g provider.

akinross · 2024-09-11T10:59:25Z

aci/data_source_aci_fabricnodeidentp.go

+
+			"commission": &schema.Schema{
+				Type:     schema.TypeString,
+				Optional: true,


could you provide explanation why?

removed optional, for commission and for the rest changes are not made as discussed

legacy-docs/docs/r/fabric_node_member.html.markdown

samiib

LGTM

legacy-docs/docs/d/fabric_node_member.html.markdown

legacy-docs/docs/r/fabric_node_member.html.markdown

aci/resource_aci_fabricnodeidentp.go

akinross · 2024-09-12T08:11:30Z

aci/resource_aci_fabricnodeidentp.go


 	log.Printf("[DEBUG] %s: Destroy finished successfully", d.Id())

 	d.SetId("")
 	return diag.FromErr(err)
 }
+func verifyNodeAttachedToSwitch(aciClient *client.Client, serial string) (bool, error) {
+	switchStatusDn := fmt.Sprintf("client-[%s]", serial)


see code below where I think it is possible to log the end of this and thus to outcome of the function

aci/resource_aci_fabricnodeidentp.go

…unction.

akinross · 2024-09-13T05:27:46Z

legacy-docs/docs/r/fabric_node_member.html.markdown

+
+### Read-Only ###
+
+* `id` - (string) The distinguished name (DN) of the Fabric Node Member object.


akinross · 2024-09-13T05:27:52Z

legacy-docs/docs/r/fabric_node_member.html.markdown

- `pod_id` - (Optional) The pod id of the new Fabric Node Member. Allowed value range: "1" - "254". Default value: "1".
- `role` - (Optional) Role for the new Fabric Node Member. 
-  Allowed values: "unspecified", "leaf", "spine". Default value: "unspecified".
+* `annotation` (annotation) - (string) Specifies the annotation of a Fabric Node Member.


anvitha-jain added the bug label Aug 6, 2024

anvitha-jain requested review from lhercot, shrsr, akinross, sajagana, samiib and gmicol August 6, 2024 15:54

anvitha-jain self-assigned this Aug 6, 2024

anvitha-jain linked an issue Aug 6, 2024 that may be closed by this pull request

aci_fabric_node_member resource do not remove node from inventory (DCNE-152) #1214

Open

anvitha-jain force-pushed the fabric_node_member branch from 7122b06 to 84bde0c Compare August 8, 2024 18:18

samiib changed the title ~~[bugfix] Resolves deletion of nodes from controller upon destroy~~ [bugfix] Resolves deletion of nodes from controller upon destroy (DCNE-152) Aug 14, 2024

anvitha-jain force-pushed the fabric_node_member branch from 7a85443 to e194936 Compare August 15, 2024 18:56

gmicol requested changes Aug 16, 2024

View reviewed changes

aci/resource_aci_fabricnodeidentp.go Outdated Show resolved Hide resolved

anvitha-jain added the jira-sync Sync this issue to Jira label Aug 16, 2024

samiib requested changes Aug 19, 2024

View reviewed changes

docs/data-sources/fabric_node_member.md Show resolved Hide resolved

aci/resource_aci_fabricnodeidentp.go Show resolved Hide resolved

anvitha-jain requested review from samiib and gmicol August 19, 2024 22:51

github-actions bot changed the title ~~[bugfix] Resolves deletion of nodes from controller upon destroy (DCNE-152)~~ [bugfix] Resolves deletion of nodes from controller upon destroy (DCNE-152) (DCNE-159) Aug 20, 2024

samiib previously approved these changes Aug 20, 2024

View reviewed changes

shrsr requested changes Aug 21, 2024

View reviewed changes

aci/resource_aci_fabricnodeidentp.go Show resolved Hide resolved

aci/resource_aci_fabricnodeidentp.go Outdated Show resolved Hide resolved

aci/resource_aci_fabricnodeidentp.go Show resolved Hide resolved

anvitha-jain dismissed samiib’s stale review via 8d4094d August 21, 2024 20:19

anvitha-jain force-pushed the fabric_node_member branch from 0ab8475 to 8d4094d Compare August 21, 2024 20:19

anvitha-jain requested review from shrsr and samiib August 21, 2024 20:20

shrsr requested changes Aug 21, 2024

View reviewed changes

aci/resource_aci_fabricnodeidentp.go Outdated Show resolved Hide resolved

anvitha-jain requested a review from shrsr August 21, 2024 20:54

samiib removed the jira-sync Sync this issue to Jira label Aug 22, 2024

samiib changed the title ~~[bugfix] Resolves deletion of nodes from controller upon destroy (DCNE-152) (DCNE-159)~~ [bugfix] Resolves deletion of nodes from controller upon destroy (DCNE-152) Aug 22, 2024

samiib previously approved these changes Aug 22, 2024

View reviewed changes

anvitha-jain requested review from shrsr, sajagana, gmicol and samiib September 9, 2024 17:20

shrsr previously approved these changes Sep 9, 2024

View reviewed changes

samiib previously approved these changes Sep 9, 2024

View reviewed changes

akinross requested changes Sep 10, 2024

View reviewed changes

anvitha-jain added 5 commits September 10, 2024 11:23

[bugfix] Resolves deletion of nodes from controller upon destroy.

c75c3ec

[minor_changes] Added functionality to commission a node (decommision…

44af90c

…ed but not removed from controller).

[minor_changes] Fixed documentation for adding 'commission' argument.

4702702

[ignore_changes] Fixed CI by changing documentations and re-generatin…

6564cc5

…g provider.

[ignore_chnages] Added logs in resource and fixed documentation.

8a8258a

anvitha-jain dismissed stale reviews from samiib and shrsr via 03f3dc1 September 11, 2024 04:48

anvitha-jain force-pushed the fabric_node_member branch from 025a602 to 03f3dc1 Compare September 11, 2024 04:48

anvitha-jain requested review from akinross, samiib and shrsr September 11, 2024 04:50

akinross requested changes Sep 11, 2024

View reviewed changes

[ignore_changes] Changed documentation to new format.

6fbc004

anvitha-jain force-pushed the fabric_node_member branch from 03f3dc1 to 6fbc004 Compare September 11, 2024 18:17

anvitha-jain requested a review from akinross September 11, 2024 18:18

samiib previously approved these changes Sep 12, 2024

View reviewed changes

akinross requested changes Sep 12, 2024

View reviewed changes

anvitha-jain requested a review from akinross September 12, 2024 17:06

anvitha-jain dismissed samiib’s stale review via f45e6a9 September 12, 2024 18:48

[ignore_changes] Changed decommissionFabricNodeMemberFromController f…

df3bc26

…unction.

anvitha-jain force-pushed the fabric_node_member branch from f45e6a9 to df3bc26 Compare September 12, 2024 21:03

anvitha-jain requested a review from samiib September 12, 2024 21:06

akinross requested changes Sep 13, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[bugfix] Resolves deletion of nodes from controller upon destroy (DCNE-152) #1266

[bugfix] Resolves deletion of nodes from controller upon destroy (DCNE-152) #1266

anvitha-jain commented Aug 6, 2024

codecov-commenter commented Aug 6, 2024 •

edited

Loading

gmicol left a comment

samiib left a comment

samiib left a comment

shrsr left a comment

samiib left a comment

akinross Sep 10, 2024 •

edited by anvitha-jain

Loading

akinross Sep 11, 2024 •

edited by anvitha-jain

Loading

samiib left a comment

akinross Sep 12, 2024

akinross Sep 13, 2024

akinross Sep 13, 2024


		### Read-Only ###

		* `id` - (string) The distinguished name (DN) of the Fabric Node Member object.

[bugfix] Resolves deletion of nodes from controller upon destroy (DCNE-152) #1266

Are you sure you want to change the base?

[bugfix] Resolves deletion of nodes from controller upon destroy (DCNE-152) #1266

Conversation

anvitha-jain commented Aug 6, 2024

codecov-commenter commented Aug 6, 2024 • edited Loading

Codecov Report

gmicol left a comment

Choose a reason for hiding this comment

samiib left a comment

Choose a reason for hiding this comment

samiib left a comment

Choose a reason for hiding this comment

shrsr left a comment

Choose a reason for hiding this comment

samiib left a comment

Choose a reason for hiding this comment

akinross Sep 10, 2024 • edited by anvitha-jain Loading

Choose a reason for hiding this comment

akinross Sep 11, 2024 • edited by anvitha-jain Loading

Choose a reason for hiding this comment

samiib left a comment

Choose a reason for hiding this comment

akinross Sep 12, 2024

Choose a reason for hiding this comment

akinross Sep 13, 2024

Choose a reason for hiding this comment

akinross Sep 13, 2024

Choose a reason for hiding this comment

codecov-commenter commented Aug 6, 2024 •

edited

Loading

akinross Sep 10, 2024 •

edited by anvitha-jain

Loading

akinross Sep 11, 2024 •

edited by anvitha-jain

Loading