182 existing site bd fail on create #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of ADD patch operation during create
akinross
force-pushed
the
182_existing_site_bd_fail_on_create
branch
from
fc0c543
to
57a0ce1
Compare
sajagana
reviewed
Apr 21, 2023
| _, err = msoClient.PatchbyID(fmt.Sprintf("api/v1/schemas/%s", schemaId), anpStruct) | ||
| } | ||
|
|
||
| if versionInt == 1 || err != nil { |
There was a problem hiding this comment.
What is the reason for the err != nil check?
There was a problem hiding this comment.
If the replace PATCH operation fails, we try will still try and add PATCH. This should never occur for ndo4 versions, but added as an additional safeguard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #182