Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

206 data source schema clean up #235

Merged
merged 59 commits into from
Aug 16, 2023

Conversation

akinross
Copy link
Collaborator

@akinross akinross commented Aug 3, 2023

No description provided.

…esource_mso_remote_location because response changed to exclude empty descriptions
…(Read-Only) attributes correctly for datasource_mso_role
…(Read-Only) attributes correctly for datasource_mso_label
…(Read-Only) attributes correctly and set rbac and email correctly in statefile for datasource_mso_user
…(Read-Only) attributes correctly and set cloud site attributes correctly in statefile for datasource_mso_tenant
…(Read-Only) attributes correctly and add missing attributes type, group_id, version, status, reprovision, proxy, sr_l3out, template_count for datasource_mso_site
…(Read-Only) attributes correctly for datasource_mso_service_node_type
…(Read-Only) attributes correctly and fix schema description setting to statefile for datasource_mso_schema
…(Read-Only) attributes correctly for datasource_mso_schema_template
…(Read-Only) attributes correctly for datasource_mso_schema_template_vrf
…(Read-Only) attributes correctly for datasource_mso_schema_template_vrf_contract
…(Read-Only) attributes correctly and writing multiple site_nodes to statefile for datasource_mso_schema_template_service_graph
…(Read-Only) attributes correctly for datasource_mso_schema_template_l3out
…(Read-Only) attributes correctly for datasource_mso_schema_template_filter_entry
…bnet and schema_template_bd_subnet resource and datasource
@akinross akinross force-pushed the 206_data_source_schema_clean_up branch from b0b1653 to 5a9e593 Compare August 7, 2023 15:29
@lhercot lhercot requested a review from sajagana August 8, 2023 01:35
sajagana
sajagana previously approved these changes Aug 8, 2023
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…_schema_site_external_epg_selector data source
anvitha-jain
anvitha-jain previously approved these changes Aug 9, 2023
mso/resource_mso_remote_location.go Outdated Show resolved Hide resolved
shrsr
shrsr previously approved these changes Aug 11, 2023
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sajagana
sajagana previously approved these changes Aug 14, 2023
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akinross akinross dismissed stale reviews from sajagana and shrsr via b73f88d August 15, 2023 06:28
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 55ce5b7 into CiscoDevNet:master Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants