Added mso_schema_site_contract_service_graph_listener resource to manage Azure CNC - Listeners and Rules #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sajagana
force-pushed
the
190_listers_for_azure_cloud_lb
branch
from
18e3249
to
235718e
Compare
sajagana
requested review from
lhercot,
shrsr,
akinross,
anvitha-jain,
samiib and
gmicol
akinross
requested changes
Nov 29, 2023
website/docs/r/schema_site_contract_service_graph_listener.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/schema_site_contract_service_graph_listener.html.markdown
Outdated
Show resolved
Hide resolved
mso/resource_mso_schema_site_contract_service_graph_listener.go
Outdated
Show resolved
Hide resolved
mso/resource_mso_schema_site_contract_service_graph_listener.go
Outdated
Show resolved
Hide resolved
mso/resource_mso_schema_site_contract_service_graph_listener.go
Outdated
Show resolved
Hide resolved
mso/resource_mso_schema_site_contract_service_graph_listener.go
Outdated
Show resolved
Hide resolved
mso/resource_mso_schema_site_contract_service_graph_listener.go
Outdated
Show resolved
Hide resolved
mso/resource_mso_schema_site_contract_service_graph_listener.go
Outdated
Show resolved
Hide resolved
sajagana
force-pushed
the
190_listers_for_azure_cloud_lb
branch
from
7297695
to
f117e42
Compare
…resource to manage Azure CNC Contract Service Graph Load Balancer - Listeners and Rules
…or the schema input
sajagana
force-pushed
the
190_listers_for_azure_cloud_lb
branch
from
f117e42
to
fa03a14
Compare
akinross
requested changes
Dec 22, 2023
website/docs/d/schema_site_contract_service_graph_listener.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/d/schema_site_contract_service_graph_listener.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/schema_site_contract_service_graph_listener.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/schema_site_contract_service_graph_listener.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/schema_site_contract_service_graph_listener.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/schema_site_contract_service_graph_listener.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/schema_site_contract_service_graph_listener.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/schema_site_contract_service_graph_listener.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/d/schema_site_contract_service_graph_listener.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/d/schema_site_contract_service_graph_listener.html.markdown
Outdated
Show resolved
Hide resolved
…source documentation
anvitha-jain
previously approved these changes
Jan 9, 2024
lhercot
requested changes
Jan 10, 2024
| rulesDiffBoolList = append(rulesDiffBoolList, newRuleHealthCheckMap["interval"].(int) == oldRuleHealthCheckMap["interval"].(int)) | ||
| rulesDiffBoolList = append(rulesDiffBoolList, newRuleHealthCheckMap["path"].(string) == oldRuleHealthCheckMap["path"].(string)) | ||
| rulesDiffBoolList = append(rulesDiffBoolList, newRuleHealthCheckMap["port"].(int) == oldRuleHealthCheckMap["port"].(int)) | ||
| rulesDiffBoolList = append(rulesDiffBoolList, newRuleHealthCheckMap["protocol"].(string) == oldRuleHealthCheckMap["protocol"].(string)) |
There was a problem hiding this comment.
Suggested change
| rulesDiffBoolList = append(rulesDiffBoolList, newRuleHealthCheckMap["protocol"].(string) == oldRuleHealthCheckMap["protocol"].(string)) | |
| rulesDiffBool = rulesDiffBool && newRuleHealthCheckMap["protocol"].(string) == oldRuleHealthCheckMap["protocol"].(string)) |
Apply this logic everywhere if you don't care of individual results and only need the overall value
…rce_mso_schema_site_contract_service_graph_listener.go
sajagana
dismissed stale reviews from samiib, anvitha-jain, and akinross
via
fb07cf1
…he resource_mso_schema_site_contract_service_graph_listener.go
anvitha-jain
approved these changes
Jan 11, 2024
This was referenced Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
Added mso_schema_site_contract_service_graph_listener resource to manage Azure CNC Contract Service Graph Load Balancer - Listeners and Rules