SIMPLE-6397 Added support for 3.0, updated obsolete controller versions #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrikMosko
reviewed
May 29, 2024
| @@ -114,6 +114,9 @@ def __le__(self, other): | |||
| def major_differs(self, other: Version) -> bool: | |||
| return self.major != other.major | |||
|
|
|||
| def major_lt(self, other: Version) -> bool: | |||
There was a problem hiding this comment.
Why are we not using "import semver" btw which directly obeys and implements https://semver.org/ ??
Having separate class seems pretty redundant.
There was a problem hiding this comment.
It's an extra dependency, but I agree that we should not have implemented own version.
However at this point, we would probably have to deprecate the original solution and I don't see much value in that.
tmikuska
force-pushed
the
SIMPLE-6397-support-for-3.0
branch
from
8780ecc to
da5d3d4
Compare
tmikuska
added a commit
that referenced
this pull request
Nov 21, 2024
* SIMPLE-7063 Added group_display_attribute and refactored test_auth (#122) Do not fail if importing topologies for previous CML versions * Removed unexpected behavior of import lab method (#120) When a lab with a specific title existed on a CML instance, we joined that lab instead of creating a new lab with the same title which would had been perfectly fine. I believe that this was some obsolete feature request from pre-CML 2.0 era where labs possibly were enforced to have unique titles. * SIMPLE-6969 Changed PUT to PATCH for /system/auth/config * SIMPLE-6964 Dropped smart annotation tag and font properties (#119) * SIMPLE-6883 Support for smart annotations (#118) * SIMPLE-6813 Added deployed_mac_address property to Interface (#116) * SIMPLE-6776 local groups should still work with unset group filter (#115) * SIMPLE-6827 - removed MAC address block support (#114) * Dropped support for python3.8 in github actions * SIMPLE-6834 integration tests for ldap groups (#113) * Added the virlutils option to disable SSL check via ENV (#111) * SIMPLE-6706 fixed the 'owner' attribute of a joined lab (#108) * SIMPLE-6764 ldap group tests and system auth test (#110) * SIMPLE-6615 custom mac addresses implementation (#106) * SIMPLE-6397 Added support for 2.8, updated obsolete controller versions (#102) * SIMPLE-6345 refactored API error handling for better tracebacks (#98) * SIMPLE-6506 removed/deprecated offline mode leftovers (#97) * SIMPLE-6429 fix potentially mishandled data structures (#94) * SIMPLE-6384 Added rotation attribute to ellipse and rectangle annotations (#96) * Re-added api/* to the doc source tree removed by mistake * SIMPLE-6410 SQ issues is PCL (#90)
tmikuska
added a commit
that referenced
this pull request
Nov 21, 2024
* SIMPLE-7063 Added group_display_attribute and refactored test_auth (#122) Do not fail if importing topologies for previous CML versions * Removed unexpected behavior of import lab method (#120) When a lab with a specific title existed on a CML instance, we joined that lab instead of creating a new lab with the same title which would had been perfectly fine. I believe that this was some obsolete feature request from pre-CML 2.0 era where labs possibly were enforced to have unique titles. * SIMPLE-6969 Changed PUT to PATCH for /system/auth/config * SIMPLE-6964 Dropped smart annotation tag and font properties (#119) * SIMPLE-6883 Support for smart annotations (#118) * SIMPLE-6813 Added deployed_mac_address property to Interface (#116) * SIMPLE-6776 local groups should still work with unset group filter (#115) * SIMPLE-6827 - removed MAC address block support (#114) * Dropped support for python3.8 in github actions * SIMPLE-6834 integration tests for ldap groups (#113) * Added the virlutils option to disable SSL check via ENV (#111) * SIMPLE-6706 fixed the 'owner' attribute of a joined lab (#108) * SIMPLE-6764 ldap group tests and system auth test (#110) * SIMPLE-6615 custom mac addresses implementation (#106) * SIMPLE-6397 Added support for 2.8, updated obsolete controller versions (#102) * SIMPLE-6345 refactored API error handling for better tracebacks (#98) * SIMPLE-6506 removed/deprecated offline mode leftovers (#97) * SIMPLE-6429 fix potentially mishandled data structures (#94) * SIMPLE-6384 Added rotation attribute to ellipse and rectangle annotations (#96) * Re-added api/* to the doc source tree removed by mistake * SIMPLE-6410 SQ issues is PCL (#90)
tmikuska
added a commit
that referenced
this pull request
Nov 21, 2024
* SIMPLE-7063 Added group_display_attribute and refactored test_auth (#122) Do not fail if importing topologies for previous CML versions * Removed unexpected behavior of import lab method (#120) When a lab with a specific title existed on a CML instance, we joined that lab instead of creating a new lab with the same title which would had been perfectly fine. I believe that this was some obsolete feature request from pre-CML 2.0 era where labs possibly were enforced to have unique titles. * SIMPLE-6969 Changed PUT to PATCH for /system/auth/config * SIMPLE-6964 Dropped smart annotation tag and font properties (#119) * SIMPLE-6883 Support for smart annotations (#118) * SIMPLE-6813 Added deployed_mac_address property to Interface (#116) * SIMPLE-6776 local groups should still work with unset group filter (#115) * SIMPLE-6827 - removed MAC address block support (#114) * Dropped support for python3.8 in github actions * SIMPLE-6834 integration tests for ldap groups (#113) * Added the virlutils option to disable SSL check via ENV (#111) * SIMPLE-6706 fixed the 'owner' attribute of a joined lab (#108) * SIMPLE-6764 ldap group tests and system auth test (#110) * SIMPLE-6615 custom mac addresses implementation (#106) * SIMPLE-6397 Added support for 2.8, updated obsolete controller versions (#102) * SIMPLE-6345 refactored API error handling for better tracebacks (#98) * SIMPLE-6506 removed/deprecated offline mode leftovers (#97) * SIMPLE-6429 fix potentially mishandled data structures (#94) * SIMPLE-6384 Added rotation attribute to ellipse and rectangle annotations (#96) * Re-added api/* to the doc source tree removed by mistake * SIMPLE-6410 SQ issues is PCL (#90)
tmikuska
added a commit
that referenced
this pull request
Nov 21, 2024
* SIMPLE-7063 Added group_display_attribute and refactored test_auth (#122) Do not fail if importing topologies for previous CML versions * Removed unexpected behavior of import lab method (#120) When a lab with a specific title existed on a CML instance, we joined that lab instead of creating a new lab with the same title which would had been perfectly fine. I believe that this was some obsolete feature request from pre-CML 2.0 era where labs possibly were enforced to have unique titles. * SIMPLE-6969 Changed PUT to PATCH for /system/auth/config * SIMPLE-6964 Dropped smart annotation tag and font properties (#119) * SIMPLE-6883 Support for smart annotations (#118) * SIMPLE-6813 Added deployed_mac_address property to Interface (#116) * SIMPLE-6776 local groups should still work with unset group filter (#115) * SIMPLE-6827 - removed MAC address block support (#114) * Dropped support for python3.8 in github actions * SIMPLE-6834 integration tests for ldap groups (#113) * Added the virlutils option to disable SSL check via ENV (#111) * SIMPLE-6706 fixed the 'owner' attribute of a joined lab (#108) * SIMPLE-6764 ldap group tests and system auth test (#110) * SIMPLE-6615 custom mac addresses implementation (#106) * SIMPLE-6397 Added support for 2.8, updated obsolete controller versions (#102) * SIMPLE-6345 refactored API error handling for better tracebacks (#98) * SIMPLE-6506 removed/deprecated offline mode leftovers (#97) * SIMPLE-6429 fix potentially mishandled data structures (#94) * SIMPLE-6384 Added rotation attribute to ellipse and rectangle annotations (#96) * Re-added api/* to the doc source tree removed by mistake * SIMPLE-6410 SQ issues is PCL (#90)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.