Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ydk-go documentation generated with incorrect version #681

Closed
111pontes opened this issue Feb 6, 2018 · 0 comments
Closed

ydk-go documentation generated with incorrect version #681

111pontes opened this issue Feb 6, 2018 · 0 comments

Comments

@111pontes
Copy link
Collaborator

ydk-go documentation is generated with test as the version string instead of the actual package version. Only seems to affect core package. Bundle versions are reflected correctly in the documentation.

@ghost ghost added the golang label Feb 19, 2018
ylil93 added a commit to ylil93/ydk-gen that referenced this issue Apr 11, 2018
- generator will now look for latest version in sdk/version.json and update setup.py and CMakeLists.txt
- created templates for setup.py and CMakeLists under sdk/_common/setup_templates
- going forward, any changes to be made to setup.py or CMakeLists.txt should be applied to the templates
- going forward, to update the latest version, simply update sdk/version.json
ylil93 added a commit to ylil93/ydk-gen that referenced this issue Apr 16, 2018
- generator will now look for latest version in sdk/version.json to generate about_ydk.rst
- generator will update the version line in sdk/setup.py and sdk/CMakeLists.txt based on the json file
ylil93 added a commit to ylil93/ydk-gen that referenced this issue Apr 16, 2018
- generator will now look for latest version in sdk/version.json to generate about_ydk.rst
- generator will update the version line in sdk/setup.py and sdk/CMakeLists.txt based on the json file
ghost pushed a commit that referenced this issue Apr 17, 2018
@ghost ghost mentioned this issue Apr 17, 2018
@ghost ghost closed this as completed Apr 17, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant