Remove unused code and fix validation service to use libyang validation

sdk/cpp/core/CMakeLists.txt

@@ -72,7 +72,6 @@ set(libydk_src
     src/path/root_schema_node.cpp
     src/path/rpc.cpp
     src/path/schema_node.cpp
-    src/path/schema_value_type.cpp
     src/path/statement.cpp)
 
 set(libydk_install_headers

sdk/cpp/core/docsgen/api/services/netconf_service.rst

@@ -1,15 +1,19 @@
 NetconfService
 ==============
 
+.. toctree::
+   :maxdepth: 2
+
 .. cpp:namespace:: ydk
 
 .. cpp:enum-class:: Datastore
 
-    :param candidate: Enum representing candidate datastore
-    :param running: Enum representing running datastore
-    :param startup: Enum representing startup datastore
-    :param url: Enum representing url datastore
-    :param config: Enum representing config datastore
+Type of datastore to perform operation on
+
+    .. cpp:enumerator:: candidate
+    .. cpp:enumerator:: running
+    .. cpp:enumerator:: startup
+    .. cpp:enumerator:: url
 
 .. cpp:class:: NetconfService : public Service
 
@@ -25,16 +29,16 @@ Netconf Service class for supporting encoding and decoding C++ model API objects
 
         :param provider: An instance of :cpp:class:`NetconfServiceProvider<ydk::NetconfServiceProvider>`
         :param persist_id: Cancels a persistent confirmed commit.
-        :return: The result of the operation as bool
-        :raises: 
+        :return: true if the operation succeeds, else false
+        :raises YCPPError: If an error has occurred
 
     .. cpp:function:: bool close_session(NetconfServiceProvider & provider)
 
         Request graceful termination of a NETCONF session
 
         :param provider: An instance of :cpp:class:`NetconfServiceProvider<ydk::NetconfServiceProvider>`
-        :return: The result of the operation as bool
-        :raises: 
+        :return: true if the operation succeeds, else false
+        :raises YCPPError: If an error has occurred
 
     .. cpp:function:: bool commit(NetconfServiceProvider & provider, std::string confirmed = "", std::string confirm_timeout = "", std::string persist = "", std::string persist_id = "")
 
@@ -45,68 +49,68 @@ Netconf Service class for supporting encoding and decoding C++ model API objects
         :param confirm_timeout: An optional argument
         :param persist: An optional argument
         :param persist_id: An optional argument
-        :return: The result of the operation as bool
-        :raises: 
+        :return: true if the operation succeeds, else false
+        :raises YCPPError: If an error has occurred
 
     .. cpp:function:: bool copy_config(NetconfServiceProvider & provider, DataStore target, DataStore source)
 
         Create or replace an entire configuration datastore with the contents of another complete configuration datastore.  If the target datastore exists, it is overwritten.  Otherwise, a new one is created, if allowed.
 
         :param provider: An instance of :cpp:class:`NetconfServiceProvider<ydk::NetconfServiceProvider>`
-        :param target: The configuration being used as the destination of type :cpp:enum-class:`Datastore`
-        :param source: The configuration being used as the source of type :cpp:enum-class:`Datastore`
-        :return: The result of the operation as bool
-        :raises: 
+        :param target: The configuration being used as the destination of type :cpp:class:`Datastore`
+        :param source: The configuration being used as the source of type :cpp:class:`Datastore`
+        :return: true if the operation succeeds, else false
+        :raises YCPPError: If an error has occurred
 
     .. cpp:function:: bool copy_config(NetconfServiceProvider & provider, DataStore target, Entity& source)
 
         Create or replace an entire configuration datastore with the contents of another complete configuration datastore.  If the target datastore exists, it is overwritten.  Otherwise, a new one is created, if allowed.
 
         :param provider: An instance of :cpp:class:`NetconfServiceProvider<ydk::NetconfServiceProvider>`
-        :param target: The configuration being used as the destination of type :cpp:enum-class:`Datastore`
+        :param target: The configuration being used as the destination of type :cpp:class:`Datastore`
         :param source: The configuration being used as the source of type :cpp:class:`Entity<ydk::Entity>` 
-        :return: The result of the operation as bool 
-        :raises: 
+        :return: true if the operation succeeds, else false 
+        :raises YCPPError: If an error has occurred
 
     .. cpp:function:: bool delete_config(NetconfServiceProvider & provider, DataStore target, std::string url = "")
 
         Delete a configuration datastore.  The RUNNING configuration datastore cannot be deleted.
 
         :param provider: An instance of :cpp:class:`NetconfServiceProvider<ydk::NetconfServiceProvider>`
-        :param target: The configuration of type :cpp:enum-class:`Datastore` to be deleted
-        :param url: Required only when target is set to :cpp:enum-class:`Datastore`.:cpp:enum:`url`
-        :return: The result of the operation as bool
-        :raises: 
+        :param target: The configuration of type :cpp:class:`Datastore` to be deleted
+        :param url: Required only when target is set to :cpp:enumerator:`url<Datastore::url>`
+        :return: true if the operation succeeds, else false
+        :raises YCPPError: If an error has occurred
 
     .. cpp:function:: bool discard_changes(NetconfServiceProvider & provider)
 
         Used to revert the candidate configuration to the current running configuration
 
         :param provider: An instance of :cpp:class:`NetconfServiceProvider<ydk::NetconfServiceProvider>`
-        :return: The result of the operation as bool
-        :raises: 
+        :return: true if the operation succeeds, else false
+        :raises YCPPError: If an error has occurred
 
     .. cpp:function:: bool edit_config(NetconfServiceProvider & provider, DataStore target, Entity& config, std::string default_operation = "", std::string test_option = "", std::string error_option = "")
 
         Loads all or part of a specified configuration to the specified target configuration datastore. Allows the new configuration to be expressed using a local file, a remote file, or inline.  If the target configuration datastore does not exist, it will be created.
 
         :param provider: An instance of :cpp:class:`NetconfServiceProvider<ydk::NetconfServiceProvider>`
-        :param target: The configuration being edited of type :cpp:enum-class:`Datastore`
+        :param target: The configuration being edited of type :cpp:class:`Datastore`
         :param config: An instance of :cpp:class:`Entity<ydk::Entity>` that is a hierarchy configuration of data as defined by one of the device's data models
         :param default_operation: Selects the default operation (merge, replace, or none). The default value for this parameter is "merge".
         :param test_option: Optionally set to "test-then-set", "set", or "test-only" if the device advertises the :validate:1.1 capability
         :param error_option: Optionally set to "stop-on-error", "continue-on-error", or "rollback-on-error"
-        :return: The result of the operation as bool.
-        :raises: 
+        :return: true if the operation succeeds, else false.
+        :raises YCPPError: If an error has occurred
 
-    .. cpp:function:: std::unique_ptr<Entity> get_config(NetconfServiceProvider & provider, DataStore source, Entity& filter);
+    .. cpp:function:: std::unique_ptr<Entity> get_config(NetconfServiceProvider & provider, DataStore source, Entity& filter)
 
         Retrieve all or part of a specified configuration datastore
 
         :param provider: An instance of :cpp:class:`NetconfServiceProvider<ydk::NetconfServiceProvider>`
-        :param source: The configuration being queried of type :cpp:enum-class:`Datastore`
+        :param source: The configuration being queried of type :cpp:class:`Datastore`
         :return: The requested data as :cpp:class:`Entity<ydk::Entity>`
-        :raises: 
+        :raises YCPPError: If an error has occurred
 
     .. cpp:function:: std::unique_ptr<Entity> get(NetconfServiceProvider & provider, Entity& filter)
 
@@ -115,49 +119,49 @@ Netconf Service class for supporting encoding and decoding C++ model API objects
         :param provider: An instance of :cpp:class:`NetconfServiceProvider<ydk::NetconfServiceProvider>`
         :param filter: An instance of :cpp:class:`Entity<ydk::Entity>` that specifies the portion of the system configuration and state data to retrieve
         :return: The requested data as :cpp:class:`Entity<ydk::Entity>`
-        :raises: 
+        :raises YCPPError: If an error has occurred
 
     .. cpp:function:: bool kill_session(NetconfServiceProvider & provider, int session_id)
 
         Force the termination of a NETCONF session
 
         :param provider: An instance of :cpp:class:`NetconfServiceProvider<ydk::NetconfServiceProvider>`
         :param session_id: An instance of int that is the session identifier of the NETCONF session to be terminated
-        :return: The result of the operation as bool
-        :raises: 
+        :return: true if the operation succeeds, else false
+        :raises YCPPError: If an error has occurred
 
     .. cpp:function:: bool lock(NetconfServiceProvider & provider, DataStore target)
 
         Allows the client to lock the entire configuration datastore system of a device
 
         :param provider: An instance of :cpp:class:`NetconfServiceProvider<ydk::NetconfServiceProvider>`
-        :param target: The configuration of type :cpp:enum-class:`Datastore` to lock
-        :return: The result of the operation as bool
-        :raises: 
+        :param target: The configuration of type :cpp:class:`Datastore` to lock
+        :return: true if the operation succeeds, else false
+        :raises YCPPError: If an error has occurred
 
     .. cpp:function:: bool unlock(NetconfServiceProvider & provider, DataStore target)
 
         Used to release a configuration lock, previously obtained with the LOCK operation
 
         :param provider: An instance of :cpp:class:`NetconfServiceProvider<ydk::NetconfServiceProvider>`
-        :param target: The configuration of type DATASTORE to unlock
-        :return: The result of the operation as bool
-        :raises: 
+        :param target: The configuration of type :cpp:class:`Datastore` to unlock
+        :return: true if the operation succeeds, else false
+        :raises YCPPError: If an error has occurred
 
     .. cpp:function:: bool validate(NetconfServiceProvider & provider, DataStore source)
 
         Checks a complete configuration for syntactical and semantic errors before applying the configuration to the device
 
         :param provider: An instance of :cpp:class:`NetconfServiceProvider<ydk::NetconfServiceProvider>`
-        :param source: An instance of :cpp:enum-class:`Datastore`
-        :return: The result of the operation as bool
-        :raises: 
+        :param source: An instance of :cpp:class:`Datastore`
+        :return: true if the operation succeeds, else false
+        :raises YCPPError: If an error has occurred
 
-    .. cpp:function:: bool validate(NetconfServiceProvider & provider, Entity& source)
+    .. cpp:function:: bool validate(NetconfServiceProvider & provider, Entity& source_config)
 
         Checks a complete configuration for syntactical and semantic errors before applying the configuration to the device
 
         :param provider: An instance of :cpp:class:`NetconfServiceProvider<ydk::NetconfServiceProvider>`
         :param source: An instance of :cpp:class:`Entity<ydk::Entity>`
-        :return: The result of the operation as bool
-        :raises:
+        :return: true if the operation succeeds, else false
+        :raises YCPPError: If an error has occurred

sdk/cpp/core/docsgen/api/services/service.rst

@@ -13,6 +13,7 @@ Base class for YDK service
    :maxdepth: 2
 
    crud_service.rst
+   netconf_service.rst
    codec_service.rst
    validation_service.rst
    core_codec_service.rst

sdk/cpp/core/src/errors.cpp

@@ -72,7 +72,7 @@ ydk::YCPPOperationNotSupportedError::YCPPOperationNotSupportedError(const std::s
 //////////////////////////////////////////////////////////////////////////
 /// YCPPDataValidationError
 //////////////////////////////////////////////////////////////////////////
-ydk::path::YCPPDataValidationError::YCPPDataValidationError() : ydk::path::YCPPCoreError{"Data Validation Error"}
+ydk::path::YCPPDataValidationError::YCPPDataValidationError() : ydk::path::YCPPCoreError{ly_errmsg()}
 {
 
 }

sdk/cpp/core/src/errors.hpp

@@ -56,6 +56,14 @@ struct YCPPServiceProviderError : public YCPPError
     }
 };
 
+struct YCPPServiceError : public YCPPError
+{
+    YCPPServiceError(const std::string& msg) : YCPPError{msg}
+    {
+
+    }
+};
+
 ///
 /// @brief Illegal State Error.
 ///