Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging development branch to master #947

Merged
merged 12 commits into from
Aug 14, 2019
Merged

Conversation

ygorelik
Copy link
Collaborator

Resolved issue #800
Resolved issue #943
Resolved issue #946
Resolved issue #931

@codecov
Copy link

codecov bot commented Aug 12, 2019

Codecov Report

Merging #947 into master will increase coverage by 0.23%.
The diff coverage is 94.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #947      +/-   ##
==========================================
+ Coverage      76%   76.23%   +0.23%     
==========================================
  Files          81       72       -9     
  Lines        8418     6888    -1530     
==========================================
- Hits         6398     5251    -1147     
+ Misses       1960     1637     -323     
+ Partials       60        0      -60
Impacted Files Coverage Δ
sdk/cpp/gnmi/src/gnmi_util.cpp 74.03% <ø> (ø) ⬆️
sdk/cpp/core/src/types.hpp 94.11% <ø> (ø) ⬆️
sdk/cpp/gnmi/src/gnmi_client.cpp 84.36% <100%> (ø) ⬆️
sdk/cpp/core/src/value_list.cpp 62.94% <100%> (+1.77%) ⬆️
sdk/cpp/core/src/entity_data_node_walker.cpp 87.4% <100%> (+0.3%) ⬆️
sdk/cpp/core/tests/test_entity.cpp 84.09% <100%> (+0.82%) ⬆️
sdk/cpp/core/src/netconf_service.cpp 79.38% <100%> (+0.58%) ⬆️
sdk/cpp/core/src/common_utilities.cpp 84.65% <82.35%> (-0.09%) ⬇️
sdk/cpp/gnmi/src/gnmi_service.cpp 93.56% <87.5%> (-0.22%) ⬇️
sdk/cpp/core/src/entity_util.cpp 90.37% <96%> (+1.27%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc96a74...3c569c7. Read the comment docs.

@ygorelik ygorelik merged commit 41c7139 into CiscoDevNet:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant