Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDB IGNORE] [MDB IGNORE] Euthenia final stretch #5958

Merged
merged 30 commits into from
Jan 5, 2024

Conversation

ktoma36
Copy link
Collaborator

@ktoma36 ktoma36 commented Sep 8, 2023

About The Pull Request

(Hopefully) The final Stretch before I can start doing proper playtest and eventually the final merge of Euthenia

Why It's Good For The Game

@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 8, 2023
@ktoma36 ktoma36 changed the title Euthenia final stretch [IDB IGNORE] [MDB IGNORE] Euthenia final stretch Sep 8, 2023
@ktoma36 ktoma36 marked this pull request as draft September 8, 2023 22:20
@ktoma36
Copy link
Collaborator Author

ktoma36 commented Nov 1, 2023

My brain is goo, apologies for slow progress

@ktoma36 ktoma36 marked this pull request as ready for review January 5, 2024 08:06
silicons pushed a commit that referenced this pull request Jan 5, 2024
Copy link
Collaborator

@TheLordME TheLordME left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cant really look at the map with MDB ingnore on

code/modules/recycling/conveyor2.dm Outdated Show resolved Hide resolved
@@ -218,6 +221,8 @@
var/list/conveyors // the list of converyors that are controlled by this switch
anchored = 1

/obj/machinery/conveyor_switch/two_way_on
position = 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why we would want default on conveyors/conveyor switches

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly so I didnt have to make a var edit version, I wanted one that would be default on



/obj/machinery/disposal/wall
name = "inset disposal unit"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you test if this works? I am not sure if the bump proc is called when you are on a wall tile

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They work quite well, ive not noticed anything with bumping into them though. Is the bump proc tripping into one?

silicons pushed a commit that referenced this pull request Jan 5, 2024
@TheLordME TheLordME merged commit 0eda4b7 into Citadel-Station-13:master Jan 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants