Integrated circuits fixes and changes #5962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
size/L
silicons
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This PR aims to bring integrated circuits not only to a more up to date version but also fix some features that weren't working.
For this I have used Baystations current circuits as a working reference. I have compiled, tested and checked for runtimes.
Fixes include
As a consequence for the advanced pathfinder I had to readjust how access is given to circuits which now allows them to read the passkey of ID's, store them, send them and so on. A minor tweak also adjusts the TTS circuit to 1 second. Additionally, I have added an advanced signaler that while it behaves identical to EPv2 it is able to work the moment you print it without having to set an address (Not to mention that EPv2 often fails to create an address upon print)