Slightly reduced memory footprint of API structs and enums #1732
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
byte
which in turn should also reduce size of structs a little where usedInvalidCastException
when casting byte to generic enum inDropDownOption<TEnum>
,Note it's not possible to constraint
Enum
backing type to byte inDropDownOption
so all enums used for dropdown ui must have abyte
as backing type otherwise will throwInvalidCastException
at runtime.Whole implementation has a flaw anyways because current implementation of
SerializableUIOption
is saving value asbyte
so anyenum
larger thanbyte
will be saved and restored incorrectly. For now everything works because we don't use such bigenums
for dropdown values, so it's something to handle in the future or better avoid such use case.Build ZIP