Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a local copy of the deploy workflow. #932

Merged
merged 1 commit into from
May 15, 2024

Conversation

anoto-moniz
Copy link
Collaborator

The current version of the PyPI GitHub Action deploy workflow assumes the calling workflow is in the repo to be deployed when using Trusted Publishing: pypi/warehouse#11096

As such, putting the deploy workflow in a shared location is not supported, and leads to errors.

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in __version__.py

The current version of the PyPI GitHub Action deploy workflow assumes
the calling workflow is in the repo to be deployed when using Trusted
Publishing: pypi/warehouse#11096

As such, putting the deploy workflow in a shared location is not
supported, and leads to errors.
@anoto-moniz anoto-moniz force-pushed the bugfix/gh-actions-cannot-reuse-deploy branch from 3d1ad89 to 59146da Compare May 15, 2024 14:31
Copy link
Collaborator

@kroenlein kroenlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anoto-moniz anoto-moniz merged commit f633e07 into main May 15, 2024
16 checks passed
@anoto-moniz anoto-moniz deleted the bugfix/gh-actions-cannot-reuse-deploy branch May 15, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants