feat: restrict filtering for information system for unauth users #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuomas777
approved these changes
Dec 13, 2024
metarecord/tests/test_api.py
Outdated
| def test_function_information_system_filtering_for_unauthenticated_user( | ||
| api_client, classification, classification_2 | ||
| ): | ||
| """Filtering by information system as an unauthenticated user should have any effect""" |
There was a problem hiding this comment.
Suggested change
| """Filtering by information system as an unauthenticated user should have any effect""" | |
| """Filtering by information system as an unauthenticated user should not have any effect""" |
maybe? 🙂
|
TIEDONOHJAUS-API branch is deployed to platta: https://tiedonohjaus-pr414.api.dev.hel.ninja 🚀🚀🚀 |
The information system field content already has a restricted visibility for unauthenticated users and so should be the filtering options for that field be. Refs TIED-171
nicobav
force-pushed
the
TIED-171/infsysfiltering
branch
from
2acb5fd to
a0db379
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The information system field content already has a restricted visibility for unauthenticated users and so should be the filtering options for that field be.
Refs TIED-171