feat: core uptake 6-1-22 clean #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- @bloom-housing/backend-core@3.0.1-alpha.1 - @bloom-housing/partners@3.0.1-alpha.1 - @bloom-housing/public@3.0.1-alpha.1 - @bloom-housing/ui-components@3.0.1-alpha.1
* fix: Replaces service to use newly created * fix: Fix DOB initial values * feat(backend): extend UserUpdateDto to support email change with confirmation * fix: Update email form to use a new service * fix: updates email change language * Fix code style issues with Prettier Co-authored-by: Michal Plebanski <michalp@airnauts.com> Co-authored-by: Sean Albert <smabert@gmail.com> Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
- @bloom-housing/backend-core@3.0.1-alpha.2 - @bloom-housing/partners@3.0.1-alpha.2 - @bloom-housing/public@3.0.1-alpha.2 - @bloom-housing/ui-components@3.0.1-alpha.2
* feat: add Programs section to listings management * fix: sorting on detail page * fix: merge issues * feat: make program fetching jurisdictional * fix: replace preference with program * fix: program delete removes jurisdiction
- @bloom-housing/backend-core@3.0.1-alpha.3 - @bloom-housing/partners@3.0.1-alpha.3 - @bloom-housing/public@3.0.1-alpha.3 - @bloom-housing/ui-components@3.0.1-alpha.3
* fix: adds top level catchAll error filter * fix: removing now unused exception filter Co-authored-by: Sean Albert <smabert@gmail.com>
- @bloom-housing/backend-core@3.0.1-alpha.4 - @bloom-housing/partners@3.0.1-alpha.4 - @bloom-housing/public@3.0.1-alpha.4 - @bloom-housing/ui-components@3.0.1-alpha.4
- @bloom-housing/partners@3.0.1-alpha.5
Bumps [electron](https://github.com/electron/electron) from 13.1.7 to 13.3.0. - [Release notes](https://github.com/electron/electron/releases) - [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md) - [Commits](electron/electron@v13.1.7...v13.3.0) --- updated-dependencies: - dependency-name: electron dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [axios](https://github.com/axios/axios) from 0.21.1 to 0.21.2. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/master/CHANGELOG.md) - [Commits](axios/axios@v0.21.1...v0.21.2) --- updated-dependencies: - dependency-name: axios dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- @bloom-housing/backend-core@3.0.1-alpha.5 - @bloom-housing/partners@3.0.1-alpha.6 - @bloom-housing/public@3.0.1-alpha.5 - @bloom-housing/ui-components@3.0.1-alpha.5
* feat: Update title to be also a react node * feat: Update translations * feat: Create reusable form to add and edit users * feat: Add delete function * feat(backend): Add ON UPDATE SET NULL to application-user relation * fix: Fix type * Fix code style issues with Prettier * fix(jurisdictionResolverService): updates to return undefined if no jurisdictionName * feat: Update drawer state name * feat: Add missing translations Co-authored-by: Michal Plebanski <michalp@airnauts.com> Co-authored-by: Lint Action <lint-action@samuelmeuli.com> Co-authored-by: Sean Albert <smabert@gmail.com>
- @bloom-housing/backend-core@3.0.1-alpha.6 - @bloom-housing/partners@3.0.1-alpha.7 - @bloom-housing/public@3.0.1-alpha.6 - @bloom-housing/ui-components@3.0.1-alpha.6
) * Merge pull request #710 from CityOfDetroit/feature/add-phonenumber-to-user-entity Add phone number to user accounts. * Merge pull request #728 from CityOfDetroit/fix/modify-phone-number-test Fix user E2E tests. * Merge pull request #728 from CityOfDetroit/fix/modify-phone-number-test Fix user E2E tests. * fix: add validation groups to phoneNumber
- @bloom-housing/backend-core@3.0.1-alpha.7 - @bloom-housing/partners@3.0.1-alpha.8 - @bloom-housing/public@3.0.1-alpha.7 - @bloom-housing/ui-components@3.0.1-alpha.7
…ing#2146) * refactor: make backend a peer dependency in ui-components * fix: fix flaky test Co-authored-by: Sean Albert <smabert@gmail.com>
- @bloom-housing/shared-helpers@3.0.1-alpha.0 - @bloom-housing/partners@3.0.1-alpha.9 - @bloom-housing/public@3.0.1-alpha.8 - @bloom-housing/ui-components@3.0.1-alpha.8
- @bloom-housing/backend-core@3.0.1-alpha.8 - @bloom-housing/shared-helpers@3.0.1-alpha.1 - @bloom-housing/partners@3.0.1-alpha.10 - @bloom-housing/public@3.0.1-alpha.9
- @bloom-housing/backend-core@3.0.1-alpha.9 - @bloom-housing/shared-helpers@3.0.1-alpha.2 - @bloom-housing/partners@3.0.1-alpha.11 - @bloom-housing/public@3.0.1-alpha.10
* fix: fix: adding unit tests to the unit type picked from dev 1f8d709 * fix: fix: a11y color contrast issues with tint on ImageCard component picked from dev 5059291 * feat: feat: two new common app questions - Household Changes and Household Student picked from dev 42a752e * fix: fix: SiteHeader visual issues with long menu bars picked from dev fd6686e * feat: feat: jurisdictional email signatures picked from dev 7a146ff * fix: fix: don't send email confirmation on paper app submission picked from dev 7f83b70 * feat: feat: Updates application confirmation numbers picked from dev 75cd67b * fix: fix(backend): make it possible to filter portal users in /users endpoint picked from dev 29bf714 * feat: feat(backend): add languages (Language[]) to Jurisdiction entity picked from dev 9ceed24 * fix: feat(backend): try fixing SETEX redis e2e tests flakiness picked from dev 4087c53 * feat: feat(backend): Add user delete endpoint picked from dev a13f735 * fix: fix: improved UX for the Building Selection Criteria drawer picked from dev 4bd8b09 * feat: feat(backend): add Program entity picked from dev 492ec4d * refactor: breaking: 1837/preferences cleanup picked from dev 3ce6d5e BREAKING CHANGE: preferences model and relationships changed * feat: feat(backend): extend UserUpdateDto to support email change picked from dev 3e1fdbd * fix: 2056/user account edit fix picked from dev a15618c * refactor: 2085/adds top level catchAll exception filter picked from dev aeaa63d * feat: feat: Change unit number field type to text picked from dev f54be7c * feat(backend): improve application flagged set saving efficiency * fix: fix: updates address order picked from dev 252e014 * fix: sets programs to optoinal and updates versions * chore: chore(deps): bump electron from 13.1.7 to 13.3.0 * chore: chore(deps): bump axios from 0.21.1 to 0.21.2 * fix: adds programs service * fix: fix lisitng e2e tests * fix: fix member tests
- @bloom-housing/partners@3.0.1-alpha.12
- @bloom-housing/backend-core@3.0.1-alpha.10 - @bloom-housing/shared-helpers@3.0.1-alpha.3 - @bloom-housing/partners@3.0.1-alpha.13 - @bloom-housing/public@3.0.1-alpha.11
|
Noticing a slight discrepancy between the Show All Listings 'X' |
|
The footer on public seems to still be misaligned (as @adriencyberspace noted last bug bash) |
|
aside from what @ColinBuyck found, I think this looks good @seanmalbert |
|
There is also the issue that was in core with the blank overlay when opening a modal. We should fix that before merging. |
|
Pushed fixes, the icon fix required a bloom core change, so I would pull the new icon size change back into core post merge here |
|
@emilyjablonski Found a discrepancy in how listing tags are shown |
|
@emilyjablonski Varying opacity on hero title (dev on left, local on right) |
|
@emilyjablonski Very small one but buttons on homepage resize on smaller screen dimensions on dev but maintain their full size on the branch |
|
@emilyjablonski On mobile view, the unit group table has less spacing between itself and the dropdown menus on the branch than it does on dev. While it is technically a discrepancy, the spacing looks more natural on the PR in my opinion and curious about your thoughts on this. |
|
Updated! I did leave the last comment from @ColinBuyck because I agree that this branch's change is an improvement over dev |
|
@emilyjablonski Updates look good and overall, LGTM! Just can't provide a review since I technically created the PR :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
Please include a summary of the change and which issue(s) is addressed. Please also include relevant motivation and context. List any dependencies that are required for this change.
How Can This Be Tested/Reviewed?
Provide instructions so we can review.
Describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration.
Checklist:
yarn generate:clientand/or created a migration if I made backend changes that require themReviewer Notes:
Steps to review a PR:
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.